Sonarcloud issues fixes #3499
Merged
Sonarcloud issues fixes #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalKinas
requested review from
nikita-web-ua,
swapnil-verma-gl,
AleksanderSklorz and
dominikiwanekhyland
MichalKinas
force-pushed
the
fix-sonarcloud-issues
branch
from
f8cdb79 to
421bf24
Compare
nikita-web-ua
approved these changes
Oct 27, 2023
DenysVuika
approved these changes
Oct 27, 2023
MichalKinas
force-pushed
the
fix-sonarcloud-issues
branch
from
307bd8a to
19594c4
Compare
DenysVuika
approved these changes
Oct 27, 2023
nikita-web-ua
approved these changes
Oct 27, 2023
| @@ -62,7 +62,7 @@ export class ToggleSharedComponent implements OnInit, OnDestroy { | |||
| this.selectionState = selectionState; | |||
|
|
|||
| this.isShared = | |||
| (this.selectionState.first && this.selectionState.first.entry && (this.selectionState.first.entry as any).sharedByUser) || | |||
| (this.selectionState?.first?.entry && (this.selectionState.first.entry as any).sharedByUser) || | |||
There was a problem hiding this comment.
this line can be reduced to just (this.selectionState?.first?.entry as any)?.sharedByUser
(no need to repeat this.selectionState.first.entry twice)
AleksanderSklorz
approved these changes
Oct 27, 2023
MichalKinas
force-pushed
the
fix-sonarcloud-issues
branch
from
19594c4 to
b73a3f6
Compare
|
One e2e constantly failing, probably affected by the changes |
MichalKinas
force-pushed
the
fix-sonarcloud-issues
branch
from
d441c9b to
87bd5fd
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Fixes most of issues reported in https://sonarcloud.io/project/issues?resolved=false&types=BUG&id=Alfresco_alfresco-content-app
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: