Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint fixes and unified lint targets #3424

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Sep 7, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • fix coverage settings for the app
  • fix eslint settings using incorrect "path" import
  • unified lint defaults
  • disable @angular-eslint/template/no-call-expression due to the eslint issues
  • enable @typescript-eslint/prefer-optional-chain as a warning

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@DenysVuika DenysVuika requested a review from eromano as a code owner September 7, 2023 18:59
@DenysVuika DenysVuika merged commit 9106608 into develop Sep 8, 2023
@DenysVuika DenysVuika deleted the nx-config-cleanup branch September 8, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants