Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPS-2171][APPS-2172] Replace from moment.js to date-fns in search-filter.test and search-results-file-folders.test #3421

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

arohilaGL
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

search-filter.test and search-results-file-folders.test use moment.js

What is the new behaviour?

search-filter.test and search-results-file-folders.test's use of moment.js have been replaced to date-fns

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

This PR requires certain changes at the HXP environment as well. Should be merged keep them in cognisance.
Other information:

@rbahirsheth rbahirsheth marked this pull request as ready for review September 6, 2023 05:00
@DenysVuika DenysVuika merged commit df8b08f into develop Sep 20, 2023
@DenysVuika DenysVuika deleted the dev-arohila-APPS-2171 branch September 20, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants