Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5107] - improve gha after introducing nx workspace #3420

Merged

Conversation

dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Due to new 'affected' command NX is trying to start tests for content-ce project which has no tests and it's blocking on that step.

What is the new behaviour?
Unit tests are unblocked on CI

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dominikiwanekhyland dominikiwanekhyland marked this pull request as ready for review September 4, 2023 09:56
@dominikiwanekhyland dominikiwanekhyland changed the title Acs 5107 improve gha after introducing nx workspace 1 [ACS-5107] - improve gha after introducing nx workspace Sep 4, 2023
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-5107-improve-gha-after-introducing-nx-workspace_1 branch from b3b9116 to affdb65 Compare September 4, 2023 10:18
@DenysVuika DenysVuika merged commit 4a8faea into develop Sep 5, 2023
@DenysVuika DenysVuika deleted the ACS-5107-improve-gha-after-introducing-nx-workspace_1 branch September 5, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants