Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5654] Retain filter header in document list. #3381

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

arohilaGL
Copy link
Contributor

@arohilaGL arohilaGL commented Aug 10, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
The filters and header of the table disappears after a refresh if there are no records in the table.
https://alfresco.atlassian.net/browse/ACS-5654

What is the new behaviour?

The filters and header of the table is retained after a refresh if there are no records in the table.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@arohilaGL arohilaGL requested a review from rbahirsheth August 10, 2023 06:02
@arohilaGL arohilaGL marked this pull request as ready for review August 10, 2023 12:48
Copy link
Contributor

@DenysVuika DenysVuika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing unit tests

@arohilaGL arohilaGL requested a review from DenysVuika August 16, 2023 08:44
@arohilaGL
Copy link
Contributor Author

unit test has been added.

@arohilaGL arohilaGL merged commit bc9c581 into develop Aug 22, 2023
@arohilaGL arohilaGL deleted the dev-arohila-ACS-5654 branch August 22, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants