Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5675] replace breadcrumbs with H1 tags #3358

Merged
merged 9 commits into from
Jul 21, 2023
Merged

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Jul 20, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • replace breadcrumbs with H1 tags where applicable
  • lazy loading for details tabs, switch off animation for complex components
  • ui and layout fixes
  • fix: close details button tooltip
  • cleanup unused i18n keys
  • remove e2e testing the breadcrumb (obsolete)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-5675

@DenysVuika DenysVuika requested a review from eromano as a code owner July 20, 2023 15:39
@DenysVuika DenysVuika merged commit 9204194 into develop Jul 21, 2023
@DenysVuika DenysVuika deleted the app-ui-fixes branch July 21, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants