Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5152] Fix for File type filter getting applied before clicking apply button #3355

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

arohilaGL
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
'File type' filter gets applied without clicking on 'Apply' button. https://alfresco.atlassian.net/browse/ACS-5152

What is the new behaviour?
The filter gets applied only after clicking the apply button.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Suggestion - The id for file type filter is checkList, which is very generic and can be changed to something more specific like fileType

@arohilaGL arohilaGL requested a review from rbahirsheth July 20, 2023 11:19
@arohilaGL arohilaGL changed the title [ACS-5145] Fix for File type filter getting applied before clicking apply button [ACS-5152] Fix for File type filter getting applied before clicking apply button Jul 20, 2023
@arohilaGL arohilaGL force-pushed the dev-arohila-ACS-5152 branch from 2b85fa8 to 62e7a0b Compare July 20, 2023 11:33
@rbahirsheth rbahirsheth marked this pull request as ready for review July 24, 2023 03:50
@arohilaGL arohilaGL merged commit 118bf5b into develop Jul 24, 2023
@arohilaGL arohilaGL deleted the dev-arohila-ACS-5152 branch July 24, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants