Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5511] create library playwright tests #3318

Merged
merged 61 commits into from
Jul 18, 2023

Conversation

azakrzewski-hy
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

Test for create library on ACA is written in Protractor

What is the new behaviour?

Test for create library is written in Playwright

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Method: "goThroughPagesLookingForRowWithName()" has "isVisible()" - this is not exact as "expect()" but does validation.
Do you think after "goThroughPagesLookingForRowWithName()" method, validation of the row should be done in expect() still ? e.g.:
await myLibrariesPage.dataTable.goThroughPagesLookingForRowWithName(libraryName);
await expect(myLibrariesPage.dataTable.getRowByName(libraryName)).toBeVisible();

Or maybe we should put "goThroughPagesLookingForRowWithName()" inside expect() ? e.g.:
expect(myLibrariesPage.dataTable.goThroughPagesLookingForRowWithName(libraryName));

@azakrzewski-hy
Copy link
Contributor Author

Repeating my question from "Other information" part of the description of this PR:

Method: "goThroughPagesLookingForRowWithName()" has "isVisible()" - this is not exact as "expect()" but does validation.
Do you think after "goThroughPagesLookingForRowWithName()" method, validation of the row should be done in expect() still ? e.g.:
await myLibrariesPage.dataTable.goThroughPagesLookingForRowWithName(libraryName);
await expect(myLibrariesPage.dataTable.getRowByName(libraryName)).toBeVisible();

Or maybe we should put "goThroughPagesLookingForRowWithName()" inside expect() ? e.g.:
expect(myLibrariesPage.dataTable.goThroughPagesLookingForRowWithName(libraryName));

Mentioned method "goThroughPagesLookingForRowWithName()" is used in other methods as well and it takes time that we can run out for a test ( timeout 45000).
Please let me know what do you think of it?

@DenysVuika DenysVuika requested a review from MichalKinas July 17, 2023 16:22
@azakrzewski-hy azakrzewski-hy merged commit 4ded3b2 into develop Jul 18, 2023
@azakrzewski-hy azakrzewski-hy deleted the ACS-5511-create-library-playwright-tests branch July 18, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants