-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-5511] create library playwright tests #3318
[ACS-5511] create library playwright tests #3318
Conversation
projects/aca-playwright-shared/src/page-objects/components/aca-header.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts
Outdated
Show resolved
Hide resolved
...ts/aca-playwright-shared/src/page-objects/components/dialogs/adf-library-dialog.component.ts
Outdated
Show resolved
Hide resolved
...ts/aca-playwright-shared/src/page-objects/components/dialogs/adf-library-dialog.component.ts
Outdated
Show resolved
Hide resolved
Repeating my question from "Other information" part of the description of this PR: Method: "goThroughPagesLookingForRowWithName()" has "isVisible()" - this is not exact as "expect()" but does validation. Or maybe we should put "goThroughPagesLookingForRowWithName()" inside expect() ? e.g.: Mentioned method "goThroughPagesLookingForRowWithName()" is used in other methods as well and it takes time that we can run out for a test ( timeout 45000). |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Test for create library on ACA is written in Protractor
What is the new behaviour?
Test for create library is written in Playwright
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Method: "goThroughPagesLookingForRowWithName()" has "isVisible()" - this is not exact as "expect()" but does validation.
Do you think after "goThroughPagesLookingForRowWithName()" method, validation of the row should be done in expect() still ? e.g.:
await myLibrariesPage.dataTable.goThroughPagesLookingForRowWithName(libraryName);
await expect(myLibrariesPage.dataTable.getRowByName(libraryName)).toBeVisible();
Or maybe we should put "goThroughPagesLookingForRowWithName()" inside expect() ? e.g.:
expect(myLibrariesPage.dataTable.goThroughPagesLookingForRowWithName(libraryName));