Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests fix for new google calendar implemented #3289

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

jatin2008
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
C286327, C286332, C286333 e2e tests were failing for Share-file.tests.ts

What is the new behaviour?
I have fixed the failing e2e test cases that were impacted due to addition of new google component calendar in ADF.
Fixed e2e's - C286327, C286332, C286333

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@AleksanderSklorz
Copy link
Contributor

@jatin2008 did you check with Rafał this too? They had some problems in HxP related with that I think.

@jatin2008
Copy link
Contributor Author

@jatin2008 did you check with Rafał this too? They had some problems in HxP related with that I think.

hi @AleksanderSklorz yess I discussed with Rafal, he told me to fix the e2e's of mine, they will raise a seperate ticket for their team to fix their issue.

@AleksanderSklorz
Copy link
Contributor

@jatin2008 did you check with Rafał this too? They had some problems in HxP related with that I think.

hi @AleksanderSklorz yess I discussed with Rafal, he told me to fix the e2e's of mine, they will raise a seperate ticket for their team to fix their issue.

thank you @jatin2008

@jatin2008
Copy link
Contributor Author

@jatin2008 did you check with Rafał this too? They had some problems in HxP related with that I think.

hi @AleksanderSklorz yess I discussed with Rafal, he told me to fix the e2e's of mine, they will raise a seperate ticket for their team to fix their issue.

thank you @jatin2008

most Welcome Alek

@DenysVuika DenysVuika merged commit 4b549f1 into develop Jun 20, 2023
@DenysVuika DenysVuika deleted the dev-jatin-e2e-fix-for-google-calendar branch June 20, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants