[ACA-4709] ensure all components have encapsulation set to none #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct part of components
AleksanderSklorz
requested review from
nikita-web-ua,
swapnil-verma-gl and
MichalKinas
DenysVuika
approved these changes
Jun 13, 2023
nikita-web-ua
approved these changes
Jun 13, 2023
MichalKinas
approved these changes
Jun 13, 2023
swapnil-verma-gl
approved these changes
Jun 13, 2023
AleksanderSklorz
deleted the
ACA-4709-Ensure-all-components-have-encapsulation-set-to-None
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4709
What is the new behaviour?
All components use ViewEncapsulation.None. Added @alfresco/eslint-angular/use-none-component-view-encapsulation eslint rule to prevent this problem in the future. Removed usages of all ng-deep and host in styles.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: