[ACS-5166] Changes to Digital workspace new UI for better experience #3264
Conversation
projects/aca-content/src/lib/components/sidenav/components/sidenav-header.component.html
Outdated
Show resolved
Hide resolved
|
@arohilaGL please provide jira link in the PR description, and also screenshots of the end results. Based on my tests, the icons are broken in this PR |
|
@arohilaGL if this PR depends on other PRs, you should state this in the description. This PR relies on ADF changes |
projects/aca-content/src/lib/components/sidenav/components/sidenav-header.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
we already have material icons font, you are adding a second font there that is "Material Symbols", not "Material Icons"
app/project.json
Outdated
| @@ -95,6 +95,7 @@ | |||
| ], | |||
| "styles": [ | |||
| "app/src/assets/fonts/material-icons/material-icons.css", | |||
| "app/src/assets/fonts/material-icons/material-icons-outlined.css", | |||
There was a problem hiding this comment.
you are loading additional font on top of existing font in line 97
|
This PR is using wrong library, should be using Material Icons instead |
| @@ -16,6 +16,7 @@ | |||
| <button | |||
| [id]="actionRef.id" | |||
| [color]="data?.color || color" | |||
| [ngClass]="{'secondary-button-color': !data?.color}" | |||
There was a problem hiding this comment.
you set the "primary" color in the app config, but this is not reflected as you just force a static background
| display: flex; | ||
| } | ||
| .secondary-button-color { | ||
| background: var(--theme-app-toolbar-button-background-color); |
There was a problem hiding this comment.
how does the "primary" color in the app config matter here?
|
reworking the PR (#3287) so closing this one |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-5166
What is the new behaviour?
Design changes to new UI layout
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Alfresco/alfresco-ng2-components#8640, must be merged before merging this PR.
Other information: