Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5343] refactor Playwright framework in ACA #3261

Merged
merged 22 commits into from
Jun 16, 2023
Merged

Conversation

MichalFidor
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
Now we are able to execute the tests with the nx command. The code is placed in the right places. Things has been cleaned up.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@MichalFidor MichalFidor force-pushed the DEV-mfidor-ACS-5343 branch from b37059c to 154a25c Compare June 12, 2023 11:14
Copy link
Contributor Author

@MichalFidor MichalFidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akashrathod28 you need to change the way how you are running the tests on GHActions here : https://github.com/Alfresco/alfresco-content-app/pull/3261/files#diff-fc79da000cf778fb8dda1c2f9847c2c4ae107459e10b85a04ee7eac531cc4082R51

It's no longer npx playwright test --config <path>, it won't work. As you can see there are still errors with lack of users data. You can check it also on your local - try to execute this npx playwright... as you do it here and you will get the same issue as here on CI. You need to modify it, to execute the Playwright tests by using nx run <project>:e2e command. This is the only way how you can do that. I advise you, to create a new action yml file, which will be only for Playwright and there do all the logic.

@DenysVuika DenysVuika force-pushed the DEV-mfidor-ACS-5343 branch from a7e6d99 to bc26d48 Compare June 16, 2023 13:59
@DenysVuika DenysVuika merged commit c843a8d into develop Jun 16, 2023
@DenysVuika DenysVuika deleted the DEV-mfidor-ACS-5343 branch June 16, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants