Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5308] reduce various modules by switching to standalone #3248

Merged
merged 10 commits into from
Jun 5, 2023

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Jun 2, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • reducing ng modules and ADF modules by switching to standalone
  • migrate Trashcan to standalone
  • break dependency on MaterialModule in unit tests
  • remove language picker settings from the app config, as already covered by the language service

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-5308

@DenysVuika DenysVuika marked this pull request as ready for review June 2, 2023 15:18
@DenysVuika DenysVuika requested a review from eromano as a code owner June 2, 2023 15:18
@DenysVuika DenysVuika merged commit f4600b5 into develop Jun 5, 2023
@DenysVuika DenysVuika deleted the standalone-part-2 branch June 5, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants