Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRODSEC-6575] used date instead of datetime for datePicker implementation in Shared link dialog component in ADF #3247

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

jatin2008
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Earlier matDateTimePicker was used in ADF so type was 'datetime' which needs to be changed.

What is the new behaviour?
I have used datePicker in ADF for Shared Link Dialog component so needed to change the type of sharedLinkDateTimePickerType as 'date' instead of 'datetime'.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@jatin2008 jatin2008 requested a review from DenysVuika June 5, 2023 09:19
@DenysVuika DenysVuika merged commit f997226 into develop Jun 5, 2023
@DenysVuika DenysVuika deleted the dev-jatin-PRODSEC-6575 branch June 5, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants