Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5330] Added clearSelection() in afterEach so that tests unslect rows after test case execution #3244

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

swapnil-verma-gl
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:
    Fixing e2e test case

What is the current behaviour? (You can also link to an open issue here)
Some of the test cases were not unselecting the rows in the datatable. This was causing issues for the next test case, which would then click the row, unselecting it, while trying to 'select' the row

What is the new behaviour?
Added a datatable.clearSelection() method call after each test, to clear any rows that the test case might have selected.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…rows after they have completed their execution
@DenysVuika DenysVuika merged commit ac49a4a into develop Jun 1, 2023
@DenysVuika DenysVuika deleted the dev-swapnil-ACS-5330-fix-more-actions-e2e branch June 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants