Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5328] initial-create-folder-test #3243

Merged
merged 10 commits into from
Jun 19, 2023

Conversation

azakrzewski-hy
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Test for create folder on ACA is written in Protractor

What is the new behaviour?
Test for create folder is written in Playwright

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Please look at structure of ACA project - check if committed test meets requirements for Page Object Pattern

azakrzewski-hy and others added 9 commits June 18, 2023 17:39
…lder-aca-playwright-tests

# Conflicts:
#	projects/aca-playwright-shared/src/base-config/index.ts
#	projects/aca-playwright-shared/src/page-objects/components/aca-page-layout-header.component.ts
#	projects/aca-playwright-shared/src/page-objects/components/adf-folder-dialog.component.ts
#	projects/aca-playwright-shared/src/page-objects/components/manageRules/manage-rules.component.ts
#	projects/aca-playwright-shared/src/page-objects/pages/personal-files.page.ts
@DenysVuika DenysVuika merged commit 6046ee3 into develop Jun 19, 2023
@DenysVuika DenysVuika deleted the ACS-5328-create-folder-aca-playwright-tests branch June 19, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants