Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5304] remove unused create menu component #3233

Merged
merged 4 commits into from
May 25, 2023
Merged

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

remove unused (previously deprecated) create menu component

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-5304

Sorry, something went wrong.

@DenysVuika DenysVuika requested a review from eromano as a code owner May 25, 2023 13:19
Copy link
Contributor

@MichalKinas MichalKinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are just removing this feature right? Isn't this a breaking change for some clients who might be using it? Also if we're sure that we want to remove it I think you also need to remove the Create Menu section from application-features.md

@DenysVuika
Copy link
Contributor Author

@MichalKinas it's the big "Create" button we removed with UI redesign... for those using it in the old versions they can still use it, with the new version it's not used by the app. I will update the docs, thanks

@DenysVuika DenysVuika merged commit 71d97a1 into develop May 25, 2023
@DenysVuika DenysVuika deleted the cleanup-create-menu branch May 25, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants