-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOBILEAPPS-1707] Open in App Dialog design changes as per new design and visibility of dialog enabled after the login and is shown in case of private files as well #3225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysVuika
reviewed
May 24, 2023
DenysVuika
reviewed
May 24, 2023
projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.scss
Outdated
Show resolved
Hide resolved
DenysVuika
reviewed
May 24, 2023
projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.scss
Outdated
Show resolved
Hide resolved
DenysVuika
reviewed
May 24, 2023
projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.scss
Outdated
Show resolved
Hide resolved
DenysVuika
reviewed
May 24, 2023
projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.scss
Outdated
Show resolved
Hide resolved
DenysVuika
reviewed
May 24, 2023
projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.scss
Outdated
Show resolved
Hide resolved
DenysVuika
requested changes
May 24, 2023
projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-shared/src/lib/services/aca-mobile-app-switcher.service.ts
Outdated
Show resolved
Hide resolved
jatin2008
force-pushed
the
dev-jatin-MOBILEAPPS-1707
branch
2 times, most recently
from
May 25, 2023 16:43
7078c54
to
9f59530
Compare
projects/aca-shared/src/lib/services/aca-mobile-app-switcher.service.ts
Outdated
Show resolved
Hide resolved
projects/aca-shared/src/lib/services/aca-mobile-app-switcher.service.ts
Outdated
Show resolved
Hide resolved
projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.scss
Show resolved
Hide resolved
…r on double click
…t and name changes
…width increased and focus unset on open in app button click
jatin2008
force-pushed
the
dev-jatin-MOBILEAPPS-1707
branch
from
May 26, 2023 08:07
9f59530
to
bda2c78
Compare
AleksanderSklorz
approved these changes
May 26, 2023
DenysVuika
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: