Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBILEAPPS-1707] Open in App Dialog design changes as per new design and visibility of dialog enabled after the login and is shown in case of private files as well #3225

Merged
merged 13 commits into from
May 26, 2023

Conversation

jatin2008
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

  1. Open in App dialog was showing only after refresh the application.
  2. Open in App dialog was not showing for private files.
  3. Open in App dialog was not having button to Dowload App in case of IOS devices.
  4. Design was not as per the expectations.

What is the new behaviour?

  1. New design changes for Open In App diaog as per new design shared by Mobile Apps team.
  2. Now Open In App dialog will appear after login into the application.
  3. Now dialog Open In App dialog will appear without refreshing the page.
  4. Earlier user was not able to see Open In App diaog for private files after login which is fixed now.
  5. Now user will have the option to Download the app in case of IOS devices which was earlier not present.
  6. Test cases added for Open In app pop up component for new code changes and in Shared Link view component as well and failed test cases modified.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

  1. Open in App Dialog in case of IOS device

Screenshot from 2023-05-24 11-52-28

  1. Open in App Dialog in case of Android device

Screenshot from 2023-05-24 11-52-49

@jatin2008 jatin2008 force-pushed the dev-jatin-MOBILEAPPS-1707 branch 2 times, most recently from 7078c54 to 9f59530 Compare May 25, 2023 16:43
@jatin2008 jatin2008 marked this pull request as ready for review May 25, 2023 16:48
@jatin2008 jatin2008 requested a review from eromano as a code owner May 25, 2023 16:48
@jatin2008 jatin2008 requested a review from DenysVuika May 25, 2023 16:51
@jatin2008 jatin2008 force-pushed the dev-jatin-MOBILEAPPS-1707 branch from 9f59530 to bda2c78 Compare May 26, 2023 08:07
@jatin2008 jatin2008 merged commit 44ea088 into develop May 26, 2023
@jatin2008 jatin2008 deleted the dev-jatin-MOBILEAPPS-1707 branch May 26, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants