Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-3742] Added styles for new layout design #3137

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

Yasa-Nataliya
Copy link
Contributor

@Yasa-Nataliya Yasa-Nataliya commented Apr 21, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Screenshot from 2023-04-24 07-19-38

What is the new behaviour?
Screenshot from 2023-04-25 05-56-59

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-3742,
https://alfresco.atlassian.net/browse/ACA-4691

@DenysVuika
Copy link
Contributor

The button vertical text alignment seems to be broken, the text is not in the middle

image

@DenysVuika
Copy link
Contributor

Sidebar items have vertical text alignment problems too, if you pay attention, they are not in the center of the element
image

@Yasa-Nataliya Yasa-Nataliya force-pushed the ACS-3742-Styling-Changes branch from 3b1f186 to 4a26ff0 Compare April 25, 2023 04:12
@Yasa-Nataliya
Copy link
Contributor Author

Sidebar items have vertical text alignment problems too, if you pay attention, they are not in the center of the element image

Text alignment is fixed for buttons
Screenshot from 2023-04-25 08-16-08

@DenysVuika DenysVuika merged commit 42479d9 into develop Apr 25, 2023
@DenysVuika DenysVuika deleted the ACS-3742-Styling-Changes branch April 25, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants