[ACA-4679] Added code changes and env variables to enable DownloadPrompt and FileAutoDownload features on ACA #3127
Conversation
…itional code for enabling non-responsive file preview download and file auto download features in ACA
…ownload features. Updated variable names from 'nonResponsiveDialog' to 'downloadPrompt'
swapnil-verma-gl
force-pushed
the
dev-swapnil-ACA-4679-enable-file-download
branch
from
1e313a8 to
62b6e46
Compare
Thank you @MichalKinas. Rebased the PR and added the missing license headers. |
.github/actions/run-e2e/action.yml
Outdated
| @@ -37,6 +37,12 @@ runs: | |||
| echo "APP_CONFIG_OAUTH2_REDIRECT_LOGOUT=/" | |||
| echo "APP_CONFIG_OAUTH2_REDIRECT_LOGIN=/" | |||
| echo "APP_CONFIG_OAUTH2_REDIRECT_SILENT_IFRAME_URI={protocol}//{hostname}{:port}/assets/silent-refresh.html" | |||
| echo "APP_CONFIG_ENABLE_DOWNLOAD_PROMPT=true" | |||
There was a problem hiding this comment.
update main readme file with these variables
There was a problem hiding this comment.
Updated the README.md file. The values I added to that file are -
APP_CONFIG_ENABLE_DOWNLOAD_PROMPT=true
APP_CONFIG_ENABLE_DOWNLOAD_PROMPT_REMINDERS=true
APP_CONFIG_DOWNLOAD_PROMPT_DELAY=<time>
APP_CONFIG_DOWNLOAD_PROMPT_REMINDER_DELAY=<time>
APP_CONFIG_ENABLE_FILE_AUTO_DOWNLOAD=true
APP_CONFIG_FILE_AUTO_DOWNLOAD_SIZE_THRESHOLD_IN_MB=<file-size>
Please validate if these are correct or if we should add the actual values instead.
|
Instead of the angular service that you now have to provide in each constructor, you can create the Effect like in all other cases, and use store.dispatch |
projects/aca-content/src/lib/components/toolbar/view-node/view-node.component.ts
Show resolved
Hide resolved
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
The DownloadPrompt and FileAutoDownload features implemented and ADF are not completely visible on the ACA application. This is due to data table column overrides and missing env variable configurations
What is the new behaviour?
Updated the data table column overrides and added env variable configurations to enable the DownloadPrompt and the FileAutoDownload feature on ACA
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
More information on this feature can be found in the following JIRAs -