[ACS-4436] comparator options set as Equals only when Encoding is selected in condition in Create/Edit a rule in Manage rules same as Share application #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
suggested changes
Mar 21, 2023
projects/aca-folder-rules/src/lib/rule-details/conditions/rule-condition-fields.ts
Outdated
Show resolved
Hide resolved
pr-triage
bot
added
PR: reviewed-changes-requested
PR: unreviewed
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
TomikaArome
approved these changes
Mar 21, 2023
AleksanderSklorz
approved these changes
Mar 21, 2023
nikita-web-ua
approved these changes
Mar 21, 2023
…as Share application which was earlier “Equals, Contains, Starts with and Ends with”
jatin2008
force-pushed
the
dev-jatin-ACS-4436
branch
from
257bc33 to
c58564c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as Share application which was earlier “Equals, Contains, Starts with and Ends with”
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
we have comparator values “Equals, Contains, Starts with and Ends with” when Encoding is selected in Condition but on Share app we can see only “Equals” for Encoding.
What is the new behaviour?
comparator options set as Equals only when Encoding is selected in condition in Create/Edit a rule in Manage rules same as Share application.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: