Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-4125] Add support for the tags search facet #3070

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

TomikaArome
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/ACS-4125

What is the new behaviour?

Add new default config so that the tags facet can appear.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

{
"mincount": 1,
"field": "TAG",
"label": "Tags",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 'label' be translatable?

@TomikaArome TomikaArome force-pushed the ACS-4125-Search-add-support-for-the-Tags-facet branch from 356be08 to 99bedab Compare March 24, 2023 09:46
@TomikaArome TomikaArome merged commit 2067ad8 into develop Mar 24, 2023
@TomikaArome TomikaArome deleted the ACS-4125-Search-add-support-for-the-Tags-facet branch March 24, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants