Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix publishing upon PR merge #3056

Merged
merged 4 commits into from
Mar 13, 2023
Merged

fix publishing upon PR merge #3056

merged 4 commits into from
Mar 13, 2023

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Mar 11, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

upon merge, it takes the name of the source branch, not the target one
https://github.com/Alfresco/alfresco-content-app/actions/runs/4392942322/jobs/7693019234

What is the new behaviour?

fix publishing upon PR merge to develop (use target (develop) branch instead of the closed branch name)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@DenysVuika DenysVuika requested a review from eromano as a code owner March 11, 2023 15:38
@DenysVuika DenysVuika requested review from gionn and alxgomz March 11, 2023 16:15
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow logs you linked are not from a PR merge to master. It looks like a simple PR workflow (going back to the wf summary shows: release.yml / on: pull_request
github.base_ref will be empty on PR merge, and my understanding is that $BRANCH_NAME as returned by the alfresco-build-tools action should handle that case just fine.

@alxgomz
Copy link
Contributor

alxgomz commented Mar 13, 2023

For example in this workflow run for the same release.yml workflow you can see it's triggered from push on master and the branch name is evaluated as expected: https://github.com/Alfresco/alfresco-content-app/actions/runs/4357569097/jobs/7617039710#step:5:4

@DenysVuika
Copy link
Contributor Author

@alxgomz we need an extra "alpha" publishing, when code goes from a branch to develop, it should skip the tagging but release alphas

@DenysVuika DenysVuika requested a review from alxgomz March 13, 2023 09:51
@DenysVuika DenysVuika merged commit c996d7d into develop Mar 13, 2023
@DenysVuika DenysVuika deleted the fix-publishing branch March 13, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants