Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-3742] Layout changes for workspace #2980

Merged
merged 85 commits into from
Apr 20, 2023
Merged

[ACS-3742] Layout changes for workspace #2980

merged 85 commits into from
Apr 20, 2023

Conversation

Yasa-Nataliya
Copy link
Contributor

@Yasa-Nataliya Yasa-Nataliya commented Feb 10, 2023 •
edited by DenysVuika
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

image

Layout changes for ACA according to the ACS-3742 jira ticket.
Depends on: Alfresco/alfresco-ng2-components#8256

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

  • custom header image path is deprecated
  • custom header text color is deprecated
  • custom header color is deprecated

Other information:

https://alfresco.atlassian.net/browse/ACS-3742
https://alfresco.atlassian.net/browse/ACS-4708
https://alfresco.atlassian.net/browse/ACS-4712

@Yasa-Nataliya Yasa-Nataliya changed the title Acs 3742 workspace layout [ACS-3742] Layout changes for workspace Feb 10, 2023
DenysVuika
DenysVuika requested changes Feb 10, 2023
View reviewed changes
projects/aca-shared/src/lib/services/app.service.ts Outdated Show resolved Hide resolved
projects/aca-shared/src/lib/services/app.service.ts Outdated Show resolved Hide resolved
projects/aca-shared/src/lib/services/app.service.ts Outdated Show resolved Hide resolved
projects/aca-shared/src/lib/components/page-layout/page-layout.module.ts Outdated Show resolved Hide resolved
projects/aca-shared/src/lib/components/page-layout/page-layout.component.ts Outdated Show resolved Hide resolved
projects/aca-shared/src/lib/components/page-layout/page-layout.component.ts Outdated Show resolved Hide resolved
projects/aca-shared/src/lib/components/page-layout/page-layout.component.ts Outdated Show resolved Hide resolved
projects/aca-shared/src/lib/components/page-layout/page-layout.component.html Outdated Show resolved Hide resolved
@DenysVuika
Copy link
Contributor

You have strange UI in the about section:
image

@DenysVuika
Copy link
Contributor

Username alignment still not fixed
image

@DenysVuika
Copy link
Contributor

Please run "ng lint" and fix the issues... it won't allow you to run the rest of the tests before you do that

@DenysVuika
Copy link
Contributor

Bug: About screen, clicking Files expand/collapse redirects to personal files

@DenysVuika DenysVuika self-assigned this Feb 11, 2023
@DenysVuika DenysVuika force-pushed the ACS-3742-Workspace-Layout branch from 94517ad to dce98c1 Compare February 11, 2023 16:09
@SheenaMalhotra182 SheenaMalhotra182 force-pushed the ACS-3742-Workspace-Layout branch from ebb7a58 to 45ccfdb Compare April 19, 2023 13:56
MohinishSah
MohinishSah approved these changes Apr 19, 2023
View reviewed changes
Copy link

@MohinishSah MohinishSah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DenysVuika DenysVuika merged commit 6fac964 into develop Apr 20, 2023
@DenysVuika DenysVuika deleted the ACS-3742-Workspace-Layout branch April 20, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SheenaMalhotra182 SheenaMalhotra182 SheenaMalhotra182 left review comments

@DenysVuika DenysVuika DenysVuika approved these changes

@MohinishSah MohinishSah MohinishSah approved these changes

@KikoUK KikoUK KikoUK approved these changes

@eromano eromano Awaiting requested review from eromano

@MichalKinas MichalKinas Awaiting requested review from MichalKinas

Assignees

@DenysVuika DenysVuika

Labels
breaking change PR: merged PR: reviewed-changes-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yasa-Nataliya @DenysVuika @MichalKinas @KikoUK @MohinishSah @SheenaMalhotra182