Skip to content

Commit

Permalink
[ACS-8634] CR fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
MichalKinas committed Oct 31, 2024
1 parent f50154f commit b5722d5
Show file tree
Hide file tree
Showing 4 changed files with 61 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
/*!
* Copyright © 2005-2024 Hyland Software, Inc. and its affiliates. All rights reserved.
*
* Alfresco Example Content Application
*
* This file is part of the Alfresco Example Content Application.
* If the software was purchased under a paid Alfresco license, the terms of
* the paid license agreement will prevail. Otherwise, the software is
* provided under the following open source license terms:
*
* The Alfresco Example Content Application is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* The Alfresco Example Content Application is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
*/

import { TestBed } from '@angular/core/testing';
import { MatDialog, MatDialogModule } from '@angular/material/dialog';
import { SavedSearchesListUiService } from './saved-searches-list-ui.service';
import { SavedSearch } from '@alfresco/adf-content-services';
import { SavedSearchEditDialogComponent } from '../dialog/edit/saved-search-edit-dialog.component';
import { SavedSearchDeleteDialogComponent } from '../dialog/delete/saved-search-delete-dialog.component';

describe('NodeTemplateService', () => {
let dialog: MatDialog;
let savedSearchesListUiService: SavedSearchesListUiService;
const mockedSearch: SavedSearch = { name: 'test', encodedUrl: 'test', order: 1 };

beforeEach(() => {
TestBed.configureTestingModule({
imports: [MatDialogModule]
});

dialog = TestBed.inject(MatDialog);
savedSearchesListUiService = TestBed.inject(SavedSearchesListUiService);
});

it('should open edit save search dialog with proper params', () => {
spyOn(dialog, 'open');
savedSearchesListUiService.openEditSavedSearch(mockedSearch);

expect(dialog.open).toHaveBeenCalledWith(SavedSearchEditDialogComponent, { data: mockedSearch, width: '600px' });
});

it('should open delete save search dialog with proper params', () => {
spyOn(dialog, 'open');
savedSearchesListUiService.confirmDeleteSavedSearch(mockedSearch);

expect(dialog.open).toHaveBeenCalledWith(SavedSearchDeleteDialogComponent, { data: mockedSearch, minWidth: '500px' });
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
<button
acaActiveLink="aca-action-button--active"
[action]="child"
(actionClicked)="actionClicked.emit($event)"
[attr.aria-label]="child.title | translate"
[id]="child.id"
[attr.data-automation-id]="child.id"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
*/

import { ChangeDetectorRef, Component, EventEmitter, Input, OnInit, Output, ViewEncapsulation } from '@angular/core';
import { ChangeDetectorRef, Component, Input, OnInit, ViewEncapsulation } from '@angular/core';
import { NavBarLinkRef } from '@alfresco/adf-extensions';
import { CommonModule } from '@angular/common';
import { TranslateModule } from '@ngx-translate/core';
Expand Down Expand Up @@ -54,9 +54,6 @@ export class ExpandMenuComponent implements OnInit {
@Input()
item: NavBarLinkRef;

@Output()
actionClicked = new EventEmitter<NavBarLinkRef>();

constructor(private cd: ChangeDetectorRef) {}

ngOnInit() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,10 @@
* from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
*/

import { Directive, EventEmitter, HostListener, Input, Output } from '@angular/core';
import { Directive, HostListener, Input } from '@angular/core';
import { Params, PRIMARY_OUTLET, Router } from '@angular/router';
import { Store } from '@ngrx/store';
import { AppStore } from '@alfresco/aca-shared/store';
import { NavBarLinkRef } from '@alfresco/adf-extensions';

@Directive({
standalone: true,
Expand All @@ -37,8 +36,6 @@ import { NavBarLinkRef } from '@alfresco/adf-extensions';
export class ActionDirective {
@Input() action;

@Output() actionClicked = new EventEmitter<NavBarLinkRef>();

@HostListener('click')
onClick() {
if (this.action.url) {
Expand All @@ -49,7 +46,6 @@ export class ActionDirective {
payload: this.getNavigationCommands(this.action.click.payload)
});
}
this.actionClicked.next(this.action);
}

constructor(private router: Router, private store: Store<AppStore>) {}
Expand Down

0 comments on commit b5722d5

Please sign in to comment.