small improvements (#762)

Alfresco · Oct 29, 2018 · 66769fc · 66769fc
1 parent 1807456
commit 66769fc
Show file tree

Hide file tree

Showing 4 changed files with 66 additions and 117 deletions.
diff --git a/e2e/suites/list-views/empty-list.test.ts b/e2e/suites/list-views/empty-list.test.ts
@@ -39,7 +39,7 @@ describe('Empty list views', () => {
   const loginPage = new LoginPage();
   const logoutPage = new LogoutPage();
   const page = new BrowsingPage();
-  const { dataTable } = page;
+  const { dataTable, pagination } = page;
 
   beforeAll(async (done) => {
     await apis.admin.people.createUser({ username });
@@ -93,4 +93,64 @@ describe('Empty list views', () => {
     expect(await dataTable.getEmptyStateText()).toContain('Items you delete are moved to the Trash.');
     expect(await dataTable.getEmptyStateText()).toContain('Empty Trash to permanently delete items.');
   });
+
+  it('Favorites - pagination controls not displayed - [C280111]', async () => {
+    await page.clickFavorites();
+    expect(await pagination.range.isPresent()).toBe(false);
+    expect(await pagination.maxItems.isPresent()).toBe(false);
+    expect(await pagination.currentPage.isPresent()).toBe(false);
+    expect(await pagination.totalPages.isPresent()).toBe(false);
+    expect(await pagination.previousButton.isPresent()).toBe(false);
+    expect(await pagination.nextButton.isPresent()).toBe(false);
+  });
+
+  it('File Libraries - pagination controls not displayed - [C280084]', async () => {
+    await page.clickFileLibraries();
+    expect(await pagination.range.isPresent()).toBe(false);
+    expect(await pagination.maxItems.isPresent()).toBe(false);
+    expect(await pagination.currentPage.isPresent()).toBe(false);
+    expect(await pagination.totalPages.isPresent()).toBe(false);
+    expect(await pagination.previousButton.isPresent()).toBe(false);
+    expect(await pagination.nextButton.isPresent()).toBe(false);
+  });
+
+  it('Personal Files - pagination controls not displayed - [C280075]', async () => {
+    await page.clickPersonalFiles();
+    expect(await pagination.range.isPresent()).toBe(false);
+    expect(await pagination.maxItems.isPresent()).toBe(false);
+    expect(await pagination.currentPage.isPresent()).toBe(false);
+    expect(await pagination.totalPages.isPresent()).toBe(false);
+    expect(await pagination.previousButton.isPresent()).toBe(false);
+    expect(await pagination.nextButton.isPresent()).toBe(false);
+  });
+
+  it('Recent Files - pagination controls not displayed - [C280102]', async () => {
+    await page.clickRecentFiles();
+    expect(await pagination.range.isPresent()).toBe(false);
+    expect(await pagination.maxItems.isPresent()).toBe(false);
+    expect(await pagination.currentPage.isPresent()).toBe(false);
+    expect(await pagination.totalPages.isPresent()).toBe(false);
+    expect(await pagination.previousButton.isPresent()).toBe(false);
+    expect(await pagination.nextButton.isPresent()).toBe(false);
+  });
+
+  it('Shared Files - pagination controls not displayed - [C280094]', async () => {
+    await page.clickSharedFiles();
+    expect(await pagination.range.isPresent()).toBe(false);
+    expect(await pagination.maxItems.isPresent()).toBe(false);
+    expect(await pagination.currentPage.isPresent()).toBe(false);
+    expect(await pagination.totalPages.isPresent()).toBe(false);
+    expect(await pagination.previousButton.isPresent()).toBe(false);
+    expect(await pagination.nextButton.isPresent()).toBe(false);
+  });
+
+  it('Trash - pagination controls not displayed - [C280120]', async () => {
+    await page.clickTrash();
+    expect(await pagination.range.isPresent()).toBe(false);
+    expect(pagination.maxItems.isPresent()).toBe(false);
+    expect(pagination.currentPage.isPresent()).toBe(false);
+    expect(pagination.totalPages.isPresent()).toBe(false);
+    expect(pagination.previousButton.isPresent()).toBe(false);
+    expect(pagination.nextButton.isPresent()).toBe(false);
+  });
 });
diff --git a/e2e/suites/list-views/favorites.test.ts b/e2e/suites/list-views/favorites.test.ts
@@ -137,7 +137,7 @@ describe('Favorites', () => {
 
   it('Location column redirect - file in site - [C280485]', async () => {
     await dataTable.clickItemLocation(fileName1);
-    expect(breadcrumb.getAllItems()).toEqual([ 'File Libraries', siteName ]);
+    expect(await breadcrumb.getAllItems()).toEqual([ 'File Libraries', siteName ]);
   });
 
   it('Navigate into folder from Favorites - [C213230]', async () => {

diff --git a/e2e/suites/pagination/pag-empty-page.test.ts b/e2e/suites/pagination/pag-empty-page.test.ts
diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json
@@ -260,10 +260,10 @@
     },
     "PERMISSIONS": {
         "DIALOG": {
-            "TITLE": "Manage Permissons",
+            "TITLE": "Manage Permissions",
             "CLOSE": "Close",
-            "INHERIT_PERMISSIONS_BUTTON": "Inherit Permission",
-            "INHERITED_PERMISSIONS_BUTTON": "Permission Inherited"
+            "INHERIT_PERMISSIONS_BUTTON": "Inherit Permissions",
+            "INHERITED_PERMISSIONS_BUTTON": "Permissions Inherited"
         }
     },
     "SHARED_LINK": {
@@ -300,7 +300,7 @@
         },
         "ERRORS": {
             "GENERIC": "We hit a problem",
-            "EXISTENT_SITE": "This Library ID isn't available. Try a different Library.",
+            "EXISTENT_SITE": "This Library ID isn't available. Try a different Library ID.",
             "CONFLICT": "This Library ID is already used. Check the trashcan.",
             "ID_TOO_LONG": "Use 72 characters or less for the URL name",
             "DESCRIPTION_TOO_LONG": "Use 512 characters or less for description",