Fixes after PR comments

Alfresco · Jul 23, 2024 · 43b6816 · 43b6816
1 parent f64efd7
commit 43b6816
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/projects/aca-playwright-shared/src/page-objects/components/dataTable/mat-menu.component.ts b/projects/aca-playwright-shared/src/page-objects/components/dataTable/mat-menu.component.ts
@@ -43,14 +43,12 @@ export class MatMenuComponent extends BaseComponent {
 
   async clickMenuItem(menuItem: string): Promise<void> {
     const menuElement = this.getButtonByText(menuItem);
-    await menuElement.waitFor({ state: 'attached' });
     await menuElement.click();
     await menuElement.waitFor({ state: 'detached' });
   }
 
   async clickMenuItemFromHeaderMenu(menuItem: string): Promise<void> {
     const menuElement = this.getMenuItemFromHeaderMenu(menuItem);
-    await menuElement.waitFor({ state: 'attached' });
     await menuElement.click();
     await menuElement.waitFor({ state: 'detached' });
   }

diff --git a/projects/aca-playwright-shared/src/page-objects/components/dialogs/edit-dialog.component.ts b/projects/aca-playwright-shared/src/page-objects/components/dialogs/edit-dialog.component.ts
@@ -28,7 +28,7 @@ import { BaseComponent } from '../base.component';
 export class EditDialog extends BaseComponent {
   private static rootElement = 'mat-dialog-container';
 
-  public editDialog = this.page.locator('mat-dialog-container');
+  public editDialog = this.getChild('');
   public titleInput = this.getChild('[data-automation-id="adf-folder-dialog-title"]');
   public cancelButton = this.getChild('#adf-folder-cancel-button');
   public updateButton = this.getChild('#adf-folder-create-button');