[ACS-4538] Fix folder-rules unit tests

Alfresco · Jun 16, 2023 · 1026712 · 1026712
1 parent 2e76375
commit 1026712
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 6 deletions.
diff --git a/app/project.json b/app/project.json
@@ -253,7 +253,11 @@
         "assets": [
           "app/src/assets",
           "app/src/favicon-96x96.png",
-          "projects/aca-content/assets",
+          {
+            "glob": "**/*",
+            "input": "projects/aca-content/assets",
+            "output": "/assets"
+          },
           {
             "input": "app/.tmp",
             "output": "/",

diff --git a/projects/aca-content/folder-rules/src/manage-rules/manage-rules.smart-component.spec.ts b/projects/aca-content/folder-rules/src/manage-rules/manage-rules.smart-component.spec.ts
@@ -38,7 +38,7 @@ import {
   ruleSetWithLinkMock
 } from '../mock/rule-sets.mock';
 import { By } from '@angular/platform-browser';
-import { owningFolderIdMock, owningFolderMock } from '../mock/node.mock';
+import { getOwningFolderEntryMock, owningFolderIdMock, owningFolderMock } from '../mock/node.mock';
 import { MatDialog } from '@angular/material/dialog';
 import { ActionsService } from '../services/actions.service';
 import { FolderRuleSetsService } from '../services/folder-rule-sets.service';
@@ -54,6 +54,7 @@ describe('ManageRulesSmartComponent', () => {
   let folderRuleSetsService: FolderRuleSetsService;
   let folderRulesService: FolderRulesService;
   let actionsService: ActionsService;
+  let callApiSpy: jasmine.Spy;
 
   beforeEach(() => {
     TestBed.configureTestingModule({
@@ -82,6 +83,19 @@ describe('ManageRulesSmartComponent', () => {
     actionsService = TestBed.inject(ActionsService);
 
     spyOn(actionsService, 'loadActionDefinitions').and.stub();
+    spyOn(folderRulesService, 'getRuleSettings').and.returnValue(Promise.resolve(ruleSettingsMock));
+    callApiSpy = spyOn<any>(folderRuleSetsService, 'callApi');
+    callApiSpy
+      .withArgs(`/nodes/${owningFolderIdMock}/rule-sets?include=isLinkedTo,owningFolder,linkedToBy&skipCount=0&maxItems=100`, 'GET')
+      .and.returnValue(Promise.resolve(ownedRuleSetMock))
+      .withArgs(`/nodes/${owningFolderIdMock}/rule-sets/-default-?include=isLinkedTo,owningFolder,linkedToBy`, 'GET')
+      .and.returnValue(Promise.resolve(ownedRuleSetMock))
+      .withArgs(`/nodes/${owningFolderIdMock}?include=path%2Cproperties%2CallowableOperations%2Cpermissions`, 'GET')
+      .and.returnValue(Promise.resolve(getOwningFolderEntryMock));
+  });
+
+  afterEach(() => {
+    fixture.destroy();
   });
 
   it('should show a list of rule sets and rules', () => {

diff --git a/...ects/aca-content/folder-rules/src/rule-set-picker/rule-set-picker.smart-component.spec.ts b/...ects/aca-content/folder-rules/src/rule-set-picker/rule-set-picker.smart-component.spec.ts
@@ -25,11 +25,12 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { RuleSetPickerOptions, RuleSetPickerSmartComponent } from './rule-set-picker.smart-component';
 import { CoreTestingModule } from '@alfresco/adf-core';
-import { folderToLinkMock } from '../mock/node.mock';
+import { folderToLinkMock, otherFolderMock } from '../mock/node.mock';
 import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
 import { FolderRuleSetsService } from '../services/folder-rule-sets.service';
 import { of } from 'rxjs';
-import { ruleSetWithLinkMock, ruleSetWithNoRulesToLinkMock, ruleSetWithOwnedRulesToLinkMock } from '../mock/rule-sets.mock';
+import { ownedRuleSetMock, ruleSetWithLinkMock, ruleSetWithNoRulesToLinkMock, ruleSetWithOwnedRulesToLinkMock } from '../mock/rule-sets.mock';
+import { ContentApiService } from '../../../../aca-shared/src/public-api';
 import { By } from '@angular/platform-browser';
 
 describe('RuleSetPickerSmartComponent', () => {
@@ -38,6 +39,7 @@ describe('RuleSetPickerSmartComponent', () => {
   let folderRuleSetsService: FolderRuleSetsService;
 
   let loadRuleSetsSpy: jasmine.Spy;
+  let callApiSpy: jasmine.Spy;
 
   const dialogRef = {
     close: jasmine.createSpy('close'),
@@ -54,7 +56,18 @@ describe('RuleSetPickerSmartComponent', () => {
       imports: [CoreTestingModule],
       providers: [
         { provide: MatDialogRef, useValue: dialogRef },
-        { provide: MAT_DIALOG_DATA, useValue: dialogOptions }
+        { provide: MAT_DIALOG_DATA, useValue: dialogOptions },
+        {
+          provide: ContentApiService,
+          useValue: {
+            getNode: () => {
+              return of({ entry: folderToLinkMock });
+            },
+            getNodeInfo: () => {
+              return of(otherFolderMock);
+            }
+          }
+        }
       ]
     });
 
@@ -63,7 +76,19 @@ describe('RuleSetPickerSmartComponent', () => {
     component = fixture.componentInstance;
     component['folderRuleSetsService'] = folderRuleSetsService;
 
-    loadRuleSetsSpy = spyOn(folderRuleSetsService, 'loadRuleSets');
+    loadRuleSetsSpy = spyOn(folderRuleSetsService, 'loadRuleSets').and.callThrough();
+    callApiSpy = spyOn<any>(folderRuleSetsService, 'callApi');
+    callApiSpy
+      .withArgs(`/nodes/${dialogOptions.nodeId}/rule-sets?include=isLinkedTo,owningFolder,linkedToBy&skipCount=0&maxItems=100`, 'GET')
+      .and.returnValue(Promise.resolve(ownedRuleSetMock))
+      .withArgs(`/nodes/${dialogOptions.nodeId}/rule-sets/-default-?include=isLinkedTo,owningFolder,linkedToBy`, 'GET')
+      .and.returnValue(Promise.resolve(ownedRuleSetMock))
+      .withArgs(`/nodes/${folderToLinkMock.id}?include=path%2Cproperties%2CallowableOperations%2Cpermissions`, 'GET')
+      .and.returnValue(Promise.resolve({ entry: folderToLinkMock }));
+  });
+
+  afterEach(() => {
+    fixture.destroy();
   });
 
   it('should load the rule sets of a node once it has been selected', () => {