Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAE-28943 Include sonar scanner in build action #861

Merged
merged 10 commits into from
Jan 9, 2025
Merged

AAE-28943 Include sonar scanner in build action #861

merged 10 commits into from
Jan 9, 2025
+25 −2

Conversation

mavotto
Copy link
Contributor

@mavotto mavotto commented Jan 9, 2025 •
edited
Loading

Checklist

Description

@mavotto mavotto requested a review from a team as a code owner January 9, 2025 10:45
@mavotto mavotto marked this pull request as draft January 9, 2025 10:45
@mavotto mavotto changed the title Improvement/aae 28943 include sonar scanner in build action AAE-28943 include sonar scanner in build action Jan 9, 2025
@mavotto mavotto changed the title AAE-28943 include sonar scanner in build action AAE-28943 Include sonar scanner in build action Jan 9, 2025
@mavotto mavotto marked this pull request as ready for review January 9, 2025 12:45
pmacius
pmacius reviewed Jan 9, 2025
View reviewed changes
version.txt Outdated Show resolved Hide resolved
.github/actions/maven-build-and-tag/action.yml Outdated Show resolved Hide resolved
@pmacius pmacius requested a review from gionn January 9, 2025 14:12
@mavotto @pmacius
Update version.txt
a62f33c 
Co-authored-by: Paweł Maciusiak <[email protected]>
@mavotto mavotto requested a review from pmacius January 9, 2025 14:37
@mavotto mavotto requested a review from gionn January 9, 2025 15:04
@mavotto mavotto requested a review from gionn January 9, 2025 15:27
@mavotto mavotto enabled auto-merge (squash) January 9, 2025 15:52
@mavotto mavotto disabled auto-merge January 9, 2025 15:52
@mavotto mavotto merged commit c488565 into master Jan 9, 2025
3 checks passed
@mavotto mavotto deleted the improvement/AAE-28943-include-sonar-scanner-in-build-action branch January 9, 2025 16:06
atchertchian
atchertchian reviewed Jan 9, 2025
View reviewed changes
.github/actions/maven-build-and-tag/action.yml
aggregate-report-path:
description: 'Path of the aggregated JaCoCo report'
required: false
project-key:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(detail) could have named this one sonar-project-key for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atchertchian atchertchian atchertchian left review comments

@gionn gionn gionn approved these changes

@jesty jesty Awaiting requested review from jesty

@pmacius pmacius Awaiting requested review from pmacius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mavotto @gionn @atchertchian @pmacius