Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-28530 Fix teams notif management of multiple "needs" info #827

Merged
merged 7 commits into from
Dec 6, 2024
Merged

AAE-28530 Fix teams notif management of multiple "needs" info #827

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08aac60
AAE-28530 Fix teams notification when filling needs
atchertchian Dec 5, 2024
c9f4842
fix
atchertchian Dec 5, 2024
f70096f
fix
atchertchian Dec 5, 2024
e31dfb0
fix
atchertchian Dec 5, 2024
dfe93ee
fix
atchertchian Dec 5, 2024
c9d508d
Merge branch 'master' into improvement/AAE-28530-teams-notifications-fix
atchertchian Dec 6, 2024
0c2369c
Update version.txt
atchertchian Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/actions/send-teams-notification/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ runs:
env:
NEEDS: ${{ inputs.needs }}
run: |
NEEDS_OUTPUT=$(echo $NEEDS | jq -r 'to_entries[] | "\(.key): \(.value.result)"')
echo "result=$NEEDS_OUTPUT" >> $GITHUB_OUTPUT
echo "result<<EOF" >> $GITHUB_OUTPUT
echo $NEEDS | jq -r 'to_entries | map([.key, .value.result]|join(": ")) | join("\n\n")' >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT

- name: Compute message
id: compute-message
Expand Down
7 changes: 2 additions & 5 deletions .github/actions/send-teams-notification/tests/send-teams-notification.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,22 +257,19 @@ BATS

@test "needs" {
export NEEDS_JSON=$(<$BATS_TEST_DIRNAME/sample-needs.json)
export NEEDS=$(echo $NEEDS_JSON | jq -r 'to_entries[] | "\(.key): \(.value.result)"')
export NEEDS=$(echo $NEEDS_JSON | jq -r 'to_entries | map([.key, .value.result]|join(": ")) | join("\n\n")')

run compute-message.sh

[ "$status" -eq 0 ]

expected_output=$(cat << 'BATS'
result<<EOF
build: success\npromote: failure\n\nfix: update retry inputs to use string type\n\n* use strings\n* add tests
build: success\n\npromote: failure\n\nfix: update retry inputs to use string type\n\n* use strings\n* add tests
EOF
BATS
)

echo $output
echo $expected_output

[ "$output" = "$expected_output" ]

}
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.6.0
v8.6.1
Loading