Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-24324 Adapt Management Of Nexus Staging Repositories to Nexus 3 #725

Conversation

revatilimaye
Copy link
Contributor

@revatilimaye revatilimaye commented Aug 28, 2024

Checklist

  • Jira Reference (also in PR title): https://hyland.atlassian.net/browse/AAE-24324
  • README updated after adding/changing behaviour of an action
  • Proposed version increment for release:
    • Patch (bugfix)
    • Minor (new feature)
    • Major (breaking changes)
  • External PR link where changes has been tested:

Description

Issue Link: https://hyland.atlassian.net/browse/AAE-24324

@revatilimaye revatilimaye requested a review from a team as a code owner August 28, 2024 06:30
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
.github/actions/nexus-associate-tag/action.yml Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
.github/actions/nexus-associate-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-associate-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-associate-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-associate-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-associate-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-associate-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-move-artifacts/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-move-artifacts/action.yml Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
.github/actions/nexus-create-tag/action.yml Outdated Show resolved Hide resolved
version.txt Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few rewords in the readme, plus specifying the version of nexus which is important for the compatibility of those new actions

docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
@revatilimaye revatilimaye requested a review from gionn August 30, 2024 11:42
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the rationale behind the choice of dropping the tag feature?

Copy link
Contributor

@erdemedeiros erdemedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a open question and two small suggestions. LGTM, otherwise

.github/actions/nexus-count-artifacts/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-count-artifacts/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-move-artifacts/action.yml Outdated Show resolved Hide resolved
.github/actions/nexus-count-artifacts/action.yml Outdated Show resolved Hide resolved
@erdemedeiros
Copy link
Contributor

erdemedeiros commented Sep 2, 2024

what's the rationale behind the choice of dropping the tag feature?

@gionn, while reading the migration guidelines our initial understanding was that it was necessary to create a tag in Nexus and associate artifacts to this tag to be able to move artifacts from one repository to another. However, after experimenting with the actual API, we noticed that using groupId and version was enough for your use case, so no point on creating and maintaining two additional endpoints if they are not needed.

Copy link
Contributor

@erdemedeiros erdemedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@revatilimaye revatilimaye merged commit 077fcef into master Sep 2, 2024
4 checks passed
@revatilimaye revatilimaye deleted the improvement/AAE-24324-Adapt-management-of-Nexus-staging-repositories-to-Nexus-3 branch September 2, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants