AAE-22415 Deployment message cleanup #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm not against providing utilities to delete deployments, but reading the Jira issue, I wonder how that helps with the unneeded deployments that are produced, as I don't understand why keeping deployments that we did not want to create is an issue solved by the deletion.
Also it would be nice if we could filter on the environment name, in case not all deployments should be deleted.
But again, I'm missing the point of this cleanup.
gionn
reviewed
May 28, 2024
.github/actions/github-deployments-delete/deleteDeploymentScript.js
Outdated
Show resolved
Hide resolved
.github/actions/github-deployments-delete/deleteDeploymentScript.js
Outdated
Show resolved
Hide resolved
.github/actions/github-deployments-delete/deleteDeploymentScript.js
Outdated
Show resolved
Hide resolved
.github/actions/github-deployments-delete/deleteDeploymentScript.js
Outdated
Show resolved
Hide resolved
.github/actions/github-deployments-delete/deleteDeploymentScript.js
Outdated
Show resolved
Hide resolved
.github/actions/github-deployments-delete/deleteDeploymentScript.js
Outdated
Show resolved
Hide resolved
atchertchian
previously approved these changes
May 29, 2024
revatilimaye
force-pushed
the
feature/AAE-22415-deployment-message-cleanup
branch
from
8fe2c37 to
8991288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Issue Link: https://hyland.atlassian.net/browse/AAE-22415