Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HXOR-1114: Switch AWS ECR_Write role to OIDC role #434

Merged
merged 3 commits into from
Dec 12, 2023
Merged

HXOR-1114: Switch AWS ECR_Write role to OIDC role #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f6822d
HXOR-1114: Switch AWS ECR_Write role to OIDC role
maurizio-cacace Dec 12, 2023
a0c57a9
bump version
maurizio-cacace Dec 12, 2023
2e84fcb
bump version
maurizio-cacace Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/docker-build-image/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ inputs:
aws-role-name:
required: false
description: AWS role name
default: ECR_Write
default: GithubOIDCRole
grype-scan-enabled:
description: Defines whether a Grype scan should be executed or not
required: false
Expand Down
2 changes: 0 additions & 2 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,6 @@ When using OIDC on AWS, inputs `aws-access-key-id` and `aws-secret-access-key` c
quay-username: ${{ secrets.QUAY_USERNAME }}
quay-password: ${{ secrets.QUAY_PASSWORD }}
ghcr-token: ${{ secrets.GITHUB_TOKEN }}
aws-access-key-id: ${{ secrets.HXPS_DEV_SVC_ECR_WRITE_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.HXPS_DEV_SVC_ECR_WRITE_AWS_SECRET_ACCESS_KEY }}
aws-account-id: ${{ vars.ACCOUNT_ID }}
# aws-region: ${{ vars.AWS_REGION }} # optional
# aws-role-name: ${{ vars.AWS_ROLE_NAME }} # optional
Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v5.6.0
v5.7.0
Loading