Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAE-17459: documentation + comment fixes #339

Merged
merged 1 commit into from
Oct 30, 2023
Merged

AAE-17459: documentation + comment fixes #339

merged 1 commit into from
Oct 30, 2023

Conversation

atchertchian
Copy link
Contributor

@atchertchian atchertchian commented Oct 27, 2023 •
edited
Loading

Checklist

  • Jira Reference (also in PR title): AAE-17459
  • README updated after adding/changing behaviour of an action
  • Proposed version increment for release:
    • Patch (bugfix)
    • Minor (new feature)
    • Major (breaking changes)
  • External PR link where changes has been tested:

Description

@atchertchian atchertchian requested a review from gicappa October 27, 2023 14:00
@atchertchian atchertchian requested a review from a team as a code owner October 27, 2023 14:00
gionn
gionn approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth adding an entry in dependabot for this action given the high number of external actions

@atchertchian atchertchian merged commit ffff1ca into master Oct 30, 2023
2 checks passed
@atchertchian atchertchian deleted the fix-AAE-17459-doc branch October 30, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gicappa gicappa gicappa approved these changes

@gionn gionn gionn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atchertchian @gionn @gicappa