-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAE-11711: Improve slack notification payload #196
Conversation
atchertchian
commented
Dec 7, 2022
- fix information displayed depending on event use cases (push, pull_request, schedule, workflow_dispatch)
- fix management of messages with quotes
- improve overall display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this bash vars are prone to errors as is
Co-authored-by: Alex Chapellon <[email protected]>
Co-authored-by: Alex Chapellon <[email protected]>
Co-authored-by: Alex Chapellon <[email protected]>
Co-authored-by: Alex Chapellon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
Sorry forgot some debug echos in tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!