Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-11711: Improve slack notification payload #196

Merged
merged 9 commits into from
Dec 8, 2022

Conversation

atchertchian
Copy link
Contributor

  • fix information displayed depending on event use cases (push, pull_request, schedule, workflow_dispatch)
  • fix management of messages with quotes
  • improve overall display

Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this bash vars are prone to errors as is

@atchertchian atchertchian requested a review from alxgomz December 7, 2022 16:51
alxgomz
alxgomz previously approved these changes Dec 7, 2022
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@atchertchian
Copy link
Contributor Author

Sorry forgot some debug echos in tests

Copy link
Contributor

@erdemedeiros erdemedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atchertchian atchertchian merged commit b542252 into master Dec 8, 2022
@atchertchian atchertchian deleted the AAE-11711-improve-slack-notif-payload branch December 8, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants