Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2121 Add kics scan #947

Merged
merged 12 commits into from
Sep 25, 2024
Merged

OPSEXP-2121 Add kics scan #947

merged 12 commits into from
Sep 25, 2024

Conversation

pmacius
Copy link
Contributor

@pmacius pmacius commented Sep 23, 2024

This comment was marked as outdated.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

roles/testpositivies.tf Fixed Show fixed Hide fixed
roles/testpositivies.tf Fixed Show fixed Hide fixed
roles/testpositivies.tf Fixed Show fixed Hide fixed
roles/testpositivies.tf Fixed Show fixed Hide fixed
@pmacius pmacius requested review from gionn and alxgomz September 24, 2024 13:19
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also disable secret scanning with disable_secrets given that we are already using detect-secrets in pre-commit

.github/workflows/kics.yml Outdated Show resolved Hide resolved
.github/workflows/kics.yml Show resolved Hide resolved
.github/workflows/kics.yml Show resolved Hide resolved
.github/workflows/kics.yml Outdated Show resolved Hide resolved
@pmacius pmacius requested a review from gionn September 25, 2024 08:59
.github/workflows/kics.yml Outdated Show resolved Hide resolved
.github/workflows/kics.yml Outdated Show resolved Hide resolved
@pmacius pmacius requested a review from gionn September 25, 2024 09:13
@pmacius pmacius merged commit 30db4cb into master Sep 25, 2024
50 checks passed
@pmacius pmacius deleted the OPSEXP-2121 branch September 25, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants