Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2637: refactor postgres role to generate syncservice database credentials only when needed #894

Merged
merged 25 commits into from
Jul 3, 2024
Merged

OPSEXP-2637: refactor postgres role to generate syncservice database credentials only when needed #894

merged 25 commits into from
Jul 3, 2024

Conversation

alxgomz
Copy link
Contributor

@alxgomz alxgomz commented Jul 1, 2024

@alxgomz alxgomz force-pushed the OPSEXP-2637 branch 2 times, most recently from 7c35a0e to 8d42cf8 Compare July 1, 2024 13:40
@alxgomz alxgomz requested review from gionn and pmacius July 1, 2024 17:24
pmacius
pmacius reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also change PR title to something more than optional credentials

playbooks/secrets-init.yml Outdated Show resolved Hide resolved
@alxgomz alxgomz changed the title OPSEXP-2637: make syncservice credentials optional OPSEXP-2637: generate syncservice database credentials only when needed Jul 2, 2024
@alxgomz alxgomz force-pushed the OPSEXP-2637 branch 2 times, most recently from c795b85 to 2b733e0 Compare July 2, 2024 15:50
@alxgomz alxgomz requested a review from pmacius July 3, 2024 06:57
@alxgomz alxgomz changed the title OPSEXP-2637: generate syncservice database credentials only when needed OPSEXP-2637: refacor postgres role to generate syncservice database credentials only when needed Jul 3, 2024
@alxgomz alxgomz changed the title OPSEXP-2637: refacor postgres role to generate syncservice database credentials only when needed OPSEXP-2637: refactor postgres role to generate syncservice database credentials only when needed Jul 3, 2024
gionn
gionn requested changes Jul 3, 2024
View reviewed changes
playbooks/acs.yml Outdated Show resolved Hide resolved
roles/postgres/meta/argument_specs.yml Show resolved Hide resolved
roles/postgres/tasks/main.yml Outdated Show resolved Hide resolved
roles/postgres/tasks/setup_db.yml Outdated Show resolved Hide resolved
roles/postgres/tasks/setup_db.yml Show resolved Hide resolved
roles/postgres/tasks/setup_db.yml Show resolved Hide resolved
roles/postgres/tasks/setup_db.yml Outdated Show resolved Hide resolved
roles/postgres/tasks/setup_db.yml Outdated Show resolved Hide resolved
roles/postgres/tasks/setup_db.yml Outdated Show resolved Hide resolved
roles/sync/molecule/default/converge.yml Outdated Show resolved Hide resolved
pmacius
pmacius reviewed Jul 3, 2024
View reviewed changes
playbooks/secrets.yml Outdated Show resolved Hide resolved
@alxgomz alxgomz requested review from pmacius and gionn July 3, 2024 13:51
gionn
gionn approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the last 2 open requests but should be ok

@alxgomz alxgomz merged commit 686bbf9 into master Jul 3, 2024
51 checks passed
@alxgomz alxgomz deleted the OPSEXP-2637 branch July 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmacius pmacius pmacius approved these changes

@gionn gionn gionn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxgomz @gionn @pmacius