Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2551 Fixup redirect url configuration for adw/acc #807

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

gionn
Copy link
Member

@gionn gionn commented Mar 5, 2024

@gionn gionn self-assigned this Mar 5, 2024
@gionn gionn requested review from alxgomz and pmacius March 5, 2024 15:43
@gionn gionn marked this pull request as ready for review March 5, 2024 15:44
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should instead have a generic role param that states the context of the app, and build URLs from the role itself using this param.
What do you think?

@gionn gionn force-pushed the OPSEXP-2551-fixup-redirect-login branch from 073e1cc to 98070fb Compare March 6, 2024 08:45
@gionn gionn requested a review from alxgomz March 6, 2024 09:14
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation works for me but if I read it correctly, you're not passing the adf_app_context so it'll default to adf_app_name which are actually different from the current contexts we have:
alfresco-digital-workspace = > /workspace/
alfresco-control-center => /control-center/

roles/adf_app/tasks/main.yml Outdated Show resolved Hide resolved
roles/adf_app/tasks/main.yml Outdated Show resolved Hide resolved
roles/adf_app/tasks/main.yml Outdated Show resolved Hide resolved
roles/adf_app/tasks/main.yml Outdated Show resolved Hide resolved
roles/adf_app/tasks/main.yml Show resolved Hide resolved
@gionn
Copy link
Member Author

gionn commented Mar 6, 2024

you're not passing the adf_app_context

just a bug, now there are tests to properly validate it

@gionn gionn requested a review from alxgomz March 6, 2024 13:41
@gionn gionn merged commit a0aa832 into master Mar 7, 2024
53 checks passed
@gionn gionn deleted the OPSEXP-2551-fixup-redirect-login branch March 7, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants