Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing custom JDBC driver #730

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

morgan-patou
Copy link
Contributor

@morgan-patou morgan-patou commented Dec 6, 2023

When not using the internal DB but instead using the external one, the JDBC driver is supposed to be provided inside the configuration_files/db_connector_repo and/or configuration_files/db_connector_sync. However, the roles for the repository and sync are currently using a source value using inventory_dir, which doesn't exist apparently. It's the only 2 path using that:

$ grep -ri '/configuration_files/' playbooks roles | grep -v molecule
playbooks/pki.yml:    actual_pki_dir: "{{ pki_dir | default('../configuration_files/pki') }}"
roles/repository/tasks/main.yml:        src: "{{ inventory_dir }}/configuration_files/db_connector_repo/"
roles/repository/tasks/main.yml:        src: "{{ role_path }}/../../configuration_files/licenses/"
roles/repository/tasks/main.yml:        src: "{{ role_path }}/../../configuration_files/keystores/"
roles/nginx/tasks/vhosts.yml:        src: "{{ role_path }}/../../configuration_files/ssl_certificates/{{ item.cert_key }}"
roles/nginx/tasks/vhosts.yml:        src: "{{ role_path }}/../../configuration_files/ssl_certificates/{{ item.cert_crt }}"
roles/sync/tasks/main.yml:        src: "{{ inventory_dir }}/configuration_files/db_connector_sync/"
$
$ grep -ri inventory_dir *
roles/repository/tasks/main.yml:        src: "{{ inventory_dir }}/configuration_files/db_connector_repo/"
roles/sync/tasks/main.yml:        src: "{{ inventory_dir }}/configuration_files/db_connector_sync/"
$

As mentioned in #716, I aligned the path in this PR with the other places that used the configuration_files folder. Tested successfully, the deployment is successful and Alfresco is working properly as well.

Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need to refactor all of these to be role arguments which just provide a path, but at least now is working and consistent with similar tasks.

Thanks!

@gionn gionn self-assigned this Dec 6, 2023
@gionn gionn merged commit de91f58 into Alfresco:master Dec 6, 2023
22 checks passed
@gionn gionn changed the title Fix source path for JDBC driver on localhost Fix installing custom JDBC driver Dec 6, 2023
@morgan-patou morgan-patou deleted the copy-jdbc-driver branch February 22, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants