Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-1833 Bump imagemagick package version #506

Merged
merged 8 commits into from
Nov 18, 2022
Merged

OPSEXP-1833 Bump imagemagick package version #506

merged 8 commits into from
Nov 18, 2022

Conversation

slohe1
Copy link
Contributor

@slohe1 slohe1 commented Nov 16, 2022

@slohe1 slohe1 requested review from alxgomz and gionn November 16, 2022 14:28
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not very sustainable.
make the suffix part of the version variable, or - if not possible - create a new suffix variable to append in var files.
That way we only have one place where we need to fix things in case we update that release build number

@gionn
Copy link
Member

gionn commented Nov 16, 2022

That's not very sustainable. make the suffix part of the version variable, or - if not possible - create a new suffix variable to append in var files. That way we only have one place where we need to fix things in case we update that release build number

or get rid of imagemagick_version and just use dependencies_version.imagemagick? if someone want to use their own imagemagick packages should override the base url and version

@slohe1
Copy link
Contributor Author

slohe1 commented Nov 16, 2022

That's not very sustainable. make the suffix part of the version variable, or - if not possible - create a new suffix variable to append in var files. That way we only have one place where we need to fix things in case we update that release build number

Bumped a new variable "imagemagick_release" under dependencies_version so that its one place for both imagemagick version & release number

@slohe1 slohe1 requested a review from alxgomz November 16, 2022 18:53
@slohe1 slohe1 requested a review from gionn November 17, 2022 10:36
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the test failures it seems we have a problem with RHEL 8, test_get_rendition is always failing on integration tests, needs further investigation

then it seems there is a problem running libreoffice in the transformers role tests link

@slohe1 slohe1 requested a review from gionn November 18, 2022 08:43
@slohe1 slohe1 dismissed alxgomz’s stale review November 18, 2022 12:12

Addressed changes

@slohe1 slohe1 merged commit 5a959d6 into master Nov 18, 2022
@slohe1 slohe1 deleted the OPSEXP-1833 branch November 18, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants