Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-1636 Add enteprise search role #436

Merged
merged 41 commits into from
Oct 5, 2022
Merged

OPSEXP-1636 Add enteprise search role #436

merged 41 commits into from
Oct 5, 2022

Conversation

gionn
Copy link
Member

@gionn gionn commented Sep 21, 2022

@pr-triage pr-triage bot added the PR: draft label Sep 21, 2022
@gionn gionn self-assigned this Sep 21, 2022
@gionn gionn force-pushed the OPSEXP-1636-search-ent branch 6 times, most recently from 521f185 to 832bb65 Compare September 26, 2022 10:27
@gionn gionn changed the title OPSEXP-1636 enteprise search role OPSEXP-1636 Add enteprise search role Sep 26, 2022
@gionn gionn force-pushed the OPSEXP-1636-search-ent branch from 9c03da5 to a62b13c Compare September 26, 2022 14:47
@gionn gionn marked this pull request as ready for review September 27, 2022 13:07
@gionn gionn requested review from alxgomz and kklassa September 27, 2022 13:08
gionn
gionn commented Sep 27, 2022
View reviewed changes
molecule/default/prepare.yml Outdated Show resolved Hide resolved
roles/repository/templates/alfresco-global.properties.j2 Outdated Show resolved Hide resolved
roles/search_enterprise/molecule/default/verify.yml Outdated Show resolved Hide resolved
kklassa
kklassa previously approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@kklassa kklassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me everything looks good 🚀

alxgomz
alxgomz requested changes Sep 27, 2022
View reviewed changes
playbooks/acs.yml Show resolved Hide resolved
roles/common/defaults/main.yml Outdated Show resolved Hide resolved
roles/repository/templates/alfresco-global.properties.j2 Outdated Show resolved Hide resolved
roles/search_enterprise/molecule/default/verify.yml Outdated Show resolved Hide resolved
@gionn gionn force-pushed the OPSEXP-1636-search-ent branch from c0e68bf to 14500c3 Compare September 28, 2022 12:49
@gionn gionn requested a review from alxgomz September 29, 2022 12:31
alxgomz
alxgomz requested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last change

roles/repository/templates/alfresco-global.properties.j2 Outdated Show resolved Hide resolved
@gionn gionn force-pushed the OPSEXP-1636-search-ent branch from 7612cc8 to 7497d0b Compare October 3, 2022 10:30
@gionn gionn force-pushed the OPSEXP-1636-search-ent branch from e2f2acc to 7b1ccb4 Compare October 4, 2022 15:01
@gionn gionn requested a review from alxgomz October 4, 2022 16:17
@gionn gionn merged commit 8c3cfaf into master Oct 5, 2022
@gionn gionn deleted the OPSEXP-1636-search-ent branch October 5, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

@kklassa kklassa kklassa left review comments

Assignees

@gionn gionn

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gionn @alxgomz @kklassa