Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-1639 Allow specifying a different repository for each component #431

Merged
merged 27 commits into from
Sep 26, 2022
Merged

OPSEXP-1639 Allow specifying a different repository for each component #431

merged 27 commits into from
Sep 26, 2022

Conversation

kklassa
Copy link
Contributor

@kklassa kklassa commented Sep 15, 2022

@pr-triage pr-triage bot added the PR: draft label Sep 15, 2022
@kklassa
Copy link
Contributor Author

kklassa commented Sep 19, 2022

That's all I could think of for now, let me know if you have some suggestions about improving the current approach. I will update docs after we agree on a solution.

@kklassa kklassa requested review from alxgomz, gionn and a team September 19, 2022 14:00
gionn
gionn reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • having used dict approach instead of plain string as vars keys looks really a bad choice now (but we need to live with that until the next major release of the playbook)
  • we need to add a small paragraph somewhere in the docs to have a pointer for this new feature and its basic usage

roles/repository/tasks/main.yml Outdated Show resolved Hide resolved
@kklassa kklassa requested a review from gionn September 20, 2022 14:42
gionn
gionn reviewed Sep 21, 2022
View reviewed changes
docs/components-upgrade.md Outdated Show resolved Hide resolved
docs/components-upgrade.md Outdated Show resolved Hide resolved
docs/components-upgrade.md Outdated Show resolved Hide resolved
docs/components-upgrade.md Outdated Show resolved Hide resolved
@kklassa kklassa requested a review from gionn September 21, 2022 14:05
gionn
gionn previously approved these changes Sep 22, 2022
View reviewed changes
7.0.N-extra-vars.yml Show resolved Hide resolved
@kklassa
Copy link
Contributor Author

kklassa commented Sep 23, 2022

after modifying check_upgrades.yml the playbook no longer fails on unsupported upgrade in vagrant deployment:
image

@kklassa kklassa requested a review from gionn September 26, 2022 08:04
@kklassa kklassa requested a review from gionn September 26, 2022 12:01
@kklassa kklassa marked this pull request as ready for review September 26, 2022 12:53
@kklassa kklassa merged commit 822ac1d into master Sep 26, 2022
@kklassa kklassa deleted the OPSEXP-1639-component-repos branch September 26, 2022 12:55
@gionn gionn mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gionn gionn gionn approved these changes

@alxgomz alxgomz Awaiting requested review from alxgomz

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kklassa @gionn