-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make navbar sticky with conditional styling enhancements #442
Conversation
👷 Deploy request for delightful-daifuku-a9f6ea pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @Aman-G-upta for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
@Aman-G-upta I have asked you to go through #269 for detailed description but I think you have missed that. Please fix it, you can refer this site for the navbar sticky behaviour expected |
Maked changes as requested navbar will appear after 100vh |
@Aman-G-upta the build is failing: It says the scroll progress bar file is not found, please fix it asap |
// </div> | ||
// ); | ||
// }; | ||
|
||
function App() { | ||
const [showScroll, setShowScroll] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment @Aman-G-upta
@Aman-G-upta, I have fixed the deployment issue. There are some minor comments above. Please fix them as soon as possible so that I can merge your PR. |
I apologize for any inconvenience. Please review the changes @AlfiyaSiddique |
🎉 Thank you @Aman-G-upta Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
This pull request makes the navbar sticky and adds dynamic style adjustments for smoother UX during scrolling. Changes include:
Changes made
Please merge it @AlfiyaSiddique