Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navbar sticky with conditional styling enhancements #442

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

Aman-G-upta
Copy link
Contributor

@Aman-G-upta Aman-G-upta commented Nov 9, 2024

This pull request makes the navbar sticky and adds dynamic style adjustments for smoother UX during scrolling. Changes include:
Changes made

  • Maked navbar sticky
  • Enhanced visual transition for better user experience.

Please merge it @AlfiyaSiddique

Copy link

netlify bot commented Nov 9, 2024

👷 Deploy request for delightful-daifuku-a9f6ea pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fa8c602

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @Aman-G-upta for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.

@AlfiyaSiddique
Copy link
Owner

@Aman-G-upta I have asked you to go through #269 for detailed description but I think you have missed that.
The feature behavior should be as follows:
make the navbar sticky make sure it becomes sticky only after the first 100vh

Please fix it, you can refer this site for the navbar sticky behaviour expected
https://www.pexels.com/

@Aman-G-upta
Copy link
Contributor Author

Maked changes as requested navbar will appear after 100vh
Please merge it @AlfiyaSiddique

@AlfiyaSiddique
Copy link
Owner

@Aman-G-upta the build is failing: It says the scroll progress bar file is not found, please fix it asap
image

// </div>
// );
// };

function App() {
const [showScroll, setShowScroll] = useState(false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment @Aman-G-upta

@AlfiyaSiddique
Copy link
Owner

@Aman-G-upta, I have fixed the deployment issue. There are some minor comments above. Please fix them as soon as possible so that I can merge your PR.
Also, make sure your PR has latest updates from the master branch

@Aman-G-upta
Copy link
Contributor Author

I apologize for any inconvenience. Please review the changes @AlfiyaSiddique

@AlfiyaSiddique AlfiyaSiddique added gssoc-ext For GSSOC Extended Contribution. level 1 GSSOC level 1 Contribution - 10 points hacktoberfest-accepted labels Nov 10, 2024
@AlfiyaSiddique AlfiyaSiddique merged commit c71813b into AlfiyaSiddique:master Nov 10, 2024
1 check passed
Copy link

🎉 Thank you @Aman-G-upta Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted level 1 GSSOC level 1 Contribution - 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants