Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cheatsheet links for intro-R and scRNAseq #521
Update cheatsheet links for intro-R and scRNAseq #521
Changes from 13 commits
1cd02ca
d8a5a3d
f62abe7
53b41de
978b566
d201194
77eb6fb
f303167
f19c4ae
cc40f7b
14a9e53
9c15f26
c444097
f7ca9c1
1beccc7
88d78d7
3535f53
163bf0f
0431341
8ba3de6
5f1175b
31ee52a
0c883d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this content makes more sense as part of CONTRIBUTING.md than living here.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious about this change. I think the link to the list of all functions may be more useful than the homepage for this use case. This may also apply to the earlier ggplot2 link in the intro cheatsheet (we should be consistent either way).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, this is a general thing to come back to for consistency.
I much prefer presenting the overall landing page for the documentation, sans
reference
, because it allows them to hop anywhere in the ggplot2 docs without being strictly presented with an overwhelming list of functions, most of which will be unfamiliar to them. Maybe we need a third opinion on this one..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Middle ground: we can have it all!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting here that you didn't implement the same changes as in the intro here, but I think that is fine. I also noticed that we only apparently add one new
ggplot
command here, which makes me wonder if we need it at all. Maybe just addgeom_vline
to thegeom_hline
section from the intro and remove it from the single cell doc?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't hurt, will do.
Makes sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've decided to also delete the final description bit that suggests
geom_vline()
and friends can only be used on top of another geom.