Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Automated live (rendered) versions of the notebooks #441

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

alexslemonade-docs-bot
Copy link
Collaborator

Description:

This PR auto-generated from github actions running make-live.R with:

  • The latest notebooks on the master branch
  • The latest docker image on Dockerhub

Instruction for reviewers:

Make sure that all the notebooks have been made into _live versions appropriately and have the updates you expect.

@alexslemonade-docs-bot alexslemonade-docs-bot added the automated This PR was made automatically by github actions label Mar 15, 2021
@jaclyn-taroni
Copy link
Member

Per team meeting

@jashapiro to review intro to R/Tidyverse material and 2nd half of RNA-seq
@cansavvy to review 1st half of RNA-seq
@jaclyn-taroni to review pathway analysis

All other 👀 welcome!

@jashapiro
Copy link
Member

A note for reviewers: There seems to be a bug (or at least behavior unexpected to me) with Rmarkdown::render() that results in character vectors printing oddly when called on their own. You can see this at the following htmlpreview link:
https://htmlpreview.github.io/?https://github.com/AlexsLemonade/training-modules/blob/7517d4d1b1d288fe8920e337ee8f21c0d71db8fe/RNA-seq/02-gastric_cancer_tximeta.nb.html#file-names

In particular, the character vector prints twice, once with no quotes and lots of space. I have posted a couple places to see if there is a quick fix, but have gotten no response as yet. So for now I would say we should let this pass: it does not affect how these notebooks will render in use, only how they look in this repo.

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only looked at the RNA-seq notebooks: the -live and the rendered versions. The only comments I have are:

  • I'm noticing the same double print out issue @jashapiro mentioned about 02-gastric_cancer_tximeta.nb.html also happening in 05-nb_cell_line_DESeq2.nb.html:
    At least the problem is consistent.

Screen Shot 2021-03-16 at 8 30 29 AM

  • Should 04-nb_cell_line_tximeta.Rmd have Learning Objectives? Feels odd that its the only one without?

@jaclyn-taroni
Copy link
Member

Pathway analysis stuff LGTM

@jashapiro
Copy link
Member

  • Should 04-nb_cell_line_tximeta.Rmd have Learning Objectives? Feels odd that its the only one without?

I don't think we need it to, since that is the guided exercise and introduces no new concepts.

@jashapiro
Copy link
Member

This all looks good, but is awaiting a rerun (in progress) with the small rendering change to add max.print.

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, as it seems to have everything we need. Again, you have about 20 minutes before I push the button!

@jashapiro jashapiro merged commit df18e3a into master Mar 16, 2021
@jashapiro jashapiro deleted the auto_render_live branch March 16, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated This PR was made automatically by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants