-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: Automated live (rendered) versions of the notebooks #441
Conversation
Per team meeting @jashapiro to review intro to R/Tidyverse material and 2nd half of RNA-seq All other 👀 welcome! |
9888c5a
to
7517d4d
Compare
A note for reviewers: There seems to be a bug (or at least behavior unexpected to me) with Rmarkdown::render() that results in character vectors printing oddly when called on their own. You can see this at the following htmlpreview link: In particular, the character vector prints twice, once with no quotes and lots of space. I have posted a couple places to see if there is a quick fix, but have gotten no response as yet. So for now I would say we should let this pass: it does not affect how these notebooks will render in use, only how they look in this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only looked at the RNA-seq notebooks: the -live and the rendered versions. The only comments I have are:
- I'm noticing the same double print out issue @jashapiro mentioned about
02-gastric_cancer_tximeta.nb.html
also happening in05-nb_cell_line_DESeq2.nb.html
:
At least the problem is consistent.
- Should
04-nb_cell_line_tximeta.Rmd
have Learning Objectives? Feels odd that its the only one without?
Pathway analysis stuff LGTM |
I don't think we need it to, since that is the guided exercise and introduces no new concepts. |
This all looks good, but is awaiting a rerun (in progress) with the small rendering change to add max.print. |
7517d4d
to
027a0a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, as it seems to have everything we need. Again, you have about 20 minutes before I push the button!
Description:
This PR auto-generated from github actions running make-live.R with:
Instruction for reviewers:
Make sure that all the notebooks have been made into
_live
versions appropriately and have the updates you expect.