Merge pull request #18 from macbre/oldClassConstructors

PHP4 style constructors are deprecated in PHP7

classes/tests/critical.php

@@ -29,6 +29,7 @@ class critical {
 		'reservedNames',
 		'deprecatedFunctions',
 		'newOperatorWithReference',
+		'oldClassConstructors',
 	];
 
 	/**
@@ -133,5 +134,30 @@ public function _newOperatorWithReference($line) {
 		}
 		return false;
 	}
+
+	public function _oldClassConstructors($line) {
+		static $lastClassName = false;
+
+		// reset the name of the class that we've seen
+		if ($line === '<?php') {
+			$lastClassName = false;
+		}
+
+		// find the start of PHP class declaration
+		if (strpos($line, 'class') === 0) {
+			if (preg_match('#class (\w+)#', $line, $matches)) {
+				$lastClassName = $matches[1];
+			}
+		}
+
+		// is the class name used as the function name?
+		if ($lastClassName !== false && strpos($line, 'function') !== false) {
+			if (preg_match("#function {$lastClassName}\s?\(#", $line)) {
+				return true;
+			}
+		}
+
+		return false;
+	}
 }
 ?>

testcases.php

@@ -127,3 +127,14 @@ trait numeric { /*...*/ }
 class C {}
 $c =& new C;
 $c =&new C;
+
+// Methods with the same name as their class will not be constructors in a future version of PHP
+class FooBar {
+	var $test = 42;
+
+	function set() {}
+
+	function FooBar() {
+		// NOP
+	}
+}