Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of MaybeUninit in our float writers. #117

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Remove use of MaybeUninit in our float writers. #117

merged 1 commit into from
Sep 9, 2024

Conversation

Alexhuszagh
Copy link
Owner

This used ::assume_init which invoked undefined behavior.

@Alexhuszagh Alexhuszagh added bug Something isn't working high priority High priority A-sec Issues with potential security implications. labels Sep 9, 2024
@Alexhuszagh Alexhuszagh added this to the 1.0 milestone Sep 9, 2024
@Alexhuszagh Alexhuszagh self-assigned this Sep 9, 2024
@Alexhuszagh
Copy link
Owner Author

Part of the many patches and enhancements to ensure safety guarantees are much stronger.

@Alexhuszagh
Remove use of MaybeUninit in our floar writers.
ea7e6f2 
This used `::assume_init` which invoked undefined behavior.

- Closes #95
@Alexhuszagh Alexhuszagh changed the title Remove use of MaybeUninit in our floar writers. Remove use of MaybeUninit in our float writers. Sep 9, 2024
@Alexhuszagh Alexhuszagh merged commit e8be71d into main Sep 9, 2024
39 checks passed
@Alexhuszagh Alexhuszagh deleted the issue_95 branch September 9, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Alexhuszagh Alexhuszagh

Labels
A-sec Issues with potential security implications. bug Something isn't working high priority High priority
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

[BUG] Safety comments for MaybeUninit::assume_init calls are wrong, calls are UB
1 participant
@Alexhuszagh