This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
fix shards #67
Merged
fix shards #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 30, 2021 00:03
|
@AlexeySetevoi Could we perhaps retrigger the tests on this one? They seem related to #71 |
|
@AlexeySetevoi This needs approval from you in order to run CI tests |
README.md
Outdated
| @@ -26,11 +26,20 @@ F: You can add listen ips on top of defaults: | |||
| clickhouse_listen_host_custom: | |||
| - "192.168.0.1" | |||
| ``` | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
This looks like a misstake due to merge conflict
README.md
Outdated
| F: Or you can specify ips directly e.g. to listen on all ipv4 and ipv6 addresses: | ||
| ```yaml | ||
| clickhouse_listen_host: | ||
| - "::" | ||
| ``` | ||
| >>>>>>> 7cb5558ba9f17238a4f33d2ba3b0f5e7c6ed7003 |
There was a problem hiding this comment.
This also looks weird
| F: you can manage ttl query_log: | ||
| ```yaml | ||
| clickhouse_query_log_ttl: 'event_date + INTERVAL 7 DELETE' | ||
| ``` |
There was a problem hiding this comment.
This does not have anything to do with the fixing of shards? It should perhaps be better suited in a separate PR?
README.md
Outdated
| @@ -244,6 +253,7 @@ Including an example of how to use your role (for instance, with variables passe | |||
| quota: "default", | |||
| dbs: [ testu1,testu2,testu3 ] , | |||
| comment: "classic user with multi dbs and multi-custom network allow password"} | |||
| clickhouse_query_log_ttl: 'event_date + INTERVAL 30 DELETE' | |||
| @@ -264,6 +264,9 @@ | |||
| toStartOfHour(event_time) | |||
| --> | |||
| <partition_by>toYYYYMM(event_date)</partition_by> | |||
| {% if clickhouse_query_log_ttl is defined %} | |||
| {% endfor %} | ||
| </remote_servers> | ||
| </yandex> | ||
| </yandex> |
There was a problem hiding this comment.
This change is probaly also unintentional. You are missing final newline character
AntonFriberg
suggested changes
Mar 17, 2022
|
Thank you, I'm very inattentive, I fix it |
|
@AlexeySetevoi Could you start the CI tests on this one? |
|
@AlexeySetevoi merge? |
AntonFriberg
pushed a commit
to AntonFriberg/ansible-clickhouse
that referenced
this pull request
Mar 25, 2022
* shard * fix * add clickhouse_query_log_ttl * fix readme Co-authored-by: Maksim <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.