Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #3092 Add source support to wireplumber module #3638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Sep 24, 2024

  1. Issue-3092 Add source support to wireplumber module

    - Adds microphone support etc to the wireplumber module.
    
      The existing module hardcodes the selected node type to "Audio/Sink". This feature allows the user to override this
      via `"node-type": "Audio/Source"`.
    
    - Unlike the pulseaudio module, this change does not try to see the module manage both input and output. The same effect
      can be achieved by running two instances of the wireplumber module.
    
      This approach:
      - Works around some of the complexity overhead that seem to have caused similar PRs to stall.
      - Using separate module instances also allows both the microphone and speaker levels to be controlled with a scroll
        wheel. This is something a unified module like pulseaudio struggles with.
      - Similarly, separate instances allows the source volume level to be exposed as the state. Ie- the linear-gradient
        css patterns can be applied to both input and output.
    RowanLeeder committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    71a53eb View commit details
    Browse the repository at this point in the history
  2. Issue-3092 Add node type to wireplumber logs

    - The module only fetches nodes for "node-type". This causes the 'onMixerChanged' log to spam whenever two or more
      wireplumber modules were registered on different nodes. To reduce this the unknown node warning will now only print
      if the node is not the focus of any current module.
    RowanLeeder committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2dfef1c View commit details
    Browse the repository at this point in the history