Show workspace name in doom-modeline #1049

sebastiaanspeck · 2023-08-11T09:15:13Z

gmemstr · 2023-08-11T19:52:50Z

Testing locally, get the following. I think there's some more things that need catching @sebastiaanspeck

Debugger entered--Lisp error: (void-variable treemacs-segment)
  treemacs--setup-mode-line()
  #<subr treemacs-mode>()
  treemacs--mode-check-advice(#<subr treemacs-mode>)
  apply(treemacs--mode-check-advice #<subr treemacs-mode> nil)
  treemacs-mode()
  treemacs--init()
  treemacs(nil)
  funcall-interactively(treemacs nil)
  command-execute(treemacs)

jtl5770 · 2023-08-11T22:43:04Z

I also tested it by patching my local treemacs - it behaves still the same (no output all) when using natively compiled.

WouterSpekkink · 2023-08-12T15:54:41Z

I also tested it by patching my local treemacs - it behaves still the same (no output all) when using natively compiled.

Same here.

EDIT: Actually, for some reason I ignored the last commit (sorry!) and with that commit it works on my machine.

sebastiaanspeck · 2023-08-12T20:32:06Z

Ahh! I’ve also pushed a new workaround. Can some people test it?

WouterSpekkink · 2023-08-12T20:35:37Z

Ahh! I’ve also pushed a new workaround. Can some people test it?

#1050 solves it for me.

gmemstr · 2023-08-12T20:39:16Z

Latest push produces

Debugger entered--Lisp error: (invalid-function doom-modeline-def-segment)
  doom-modeline-def-segment(nil "Display treemacs." #(" org " 0 5 (face (:inherit (mode-line-inactive doom-modeline-buffer-minor-mode)))))
  treemacs--setup-mode-line()
  #<subr treemacs-mode>()
  treemacs--mode-check-advice(#<subr treemacs-mode>)
  apply(treemacs--mode-check-advice #<subr treemacs-mode> nil)
  treemacs-mode()
  treemacs--init()
  treemacs(nil)
  funcall-interactively(treemacs nil)
  command-execute(treemacs)

The commit prior seems to have worked at first blush, but switching workspaces throws up the same error.

sebastiaanspeck · 2023-08-12T20:54:57Z

Ahh! I’ve also pushed a new workaround. Can some people test it?

#1050 solves it for me.

Yep.. that's just the code how it was prior my proposed change to show the current workspace name in the modeline. Sad to see that my workarounds doesn't fix the issues. I've opened a issue on doom-modeline as the issue is purely related to the name you have to give to the segment and you can't use a string or symbol..

Maybe we need to merge #1050 for now and search for a good, clean and working solution together?

sebastiaanspeck · 2023-08-12T20:57:49Z

Latest push produces


Debugger entered--Lisp error: (invalid-function doom-modeline-def-segment)

  doom-modeline-def-segment(nil "Display treemacs." #(" org " 0 5 (face (:inherit (mode-line-inactive doom-modeline-buffer-minor-mode)))))

  treemacs--setup-mode-line()

  #<subr treemacs-mode>()

  treemacs--mode-check-advice(#<subr treemacs-mode>)

  apply(treemacs--mode-check-advice #<subr treemacs-mode> nil)

  treemacs-mode()

  treemacs--init()

  treemacs(nil)

  funcall-interactively(treemacs nil)

  command-execute(treemacs)

The commit prior seems to have worked at first blush, but switching workspaces throws up the same error.

Sad to hear it only works for the first time ::/

BlindingDark · 2023-08-14T04:06:17Z

~~I am on treemacs 6a6171c, after I tried compiling treemacs first and then doom-modeline, then everything fine now.~~
~~To do this (I mean compile doom-modeline after treemacs), you can just delete the whole doom-modeline folder and let it re-download/re-compile.~~

edited:
~~Doesn't work now, seems to work only once, don't know why😭~~

edited 2:
try to use eval-and-compile, it works!

(with-no-warnings
  (eval-and-compile
    (doom-modeline-def-segment treemacs
    ...

Revert until #1049 has a working solution that also works with native compilation

BlindingDark · 2023-08-15T04:46:20Z

After a few tries I found a solution (use eval-and-compile with require)

((fboundp 'doom-modeline)
 (eval-and-compile
   (require 'doom-modeline)
   (doom-modeline-def-segment treemacs
     "Display treemacs."
     (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace)))
                 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode)))
   (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs))
   (doom-modeline 'treemacs)))

It works without any warning in various cases. Please have a try!

sebastiaanspeck · 2023-08-15T05:04:30Z

This needs to be tested by others before merging another breaking change. It works on my machine :)

Needs to be tested without doom-modeline installed as well, since the GitHub Actions fail on line (require 'doom-modeline).

seagle0128 · 2023-08-15T06:18:05Z

Should load doom-modeline package before calling doom-modeline-def-segment macro.
(require 'doom-modeline) or (with-eval-after-load 'doom-modeline) is necessary.
And, please be aware that doom-modeline-def-segment is a macro.

seagle0128 · 2023-08-15T06:26:25Z

src/elisp/treemacs-mode.el

-               (doom-modeline 'treemacs))
+              ((fboundp 'doom-modeline)
+	       (eval-and-compile
+		 (require 'doom-modeline)


Should use with-eval-after-load instead of require since doom-modeline is not a dependency.

I think eval-and-compile is not necessary.

((and (fboundp 'doom-modeline) (fboundp 'doom-modeline-def-segment) (fboundp 'doom-modeline-face) (fboundp 'doom-modeline-def-modeline)) (with-eval-after-load 'doom-modeline) (doom-modeline-def-segment treemacs-workspace-name "Display treemacs workspace name." (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace))) 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode))) (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs-workspace-name)) (doom-modeline 'treemacs))

This triggers reference to free variable 'treemacs-workspace-name' again...

((fboundp 'doom-modeline) (with-eval-after-load 'doom-modeline (doom-modeline-def-segment treemacs "Display treemacs." (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace))) 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode))) (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs)) (doom-modeline 'treemacs)) )

Got this error

Debugger entered--Lisp error: (void-variable treemacs) #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_8>() eval-after-load(doom-modeline #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_8>) treemacs--setup-mode-line() #f(compiled-function () (interactive nil) #<bytecode -0x1b2d643fdaa15b7>)() treemacs--mode-check-advice(#f(compiled-function () (interactive nil) #<bytecode -0x1b2d643fdaa15b7>)) apply(treemacs--mode-check-advice #f(compiled-function () (interactive nil) #<bytecode -0x1b2d643fdaa15b7>) nil) treemacs-mode()

I think we need eval-and-compile and require because we need expand doom-modeline-def-segment macro.

If doom-modeline is byte-compiled and loaded before treemacs, no such errors occur, I think.

BlindingDark · 2023-08-15T06:45:32Z

Needs to be tested without doom-modeline installed as well, since the GitHub Actions fail on line (require 'doom-modeline).

Oh yes, I forgot this, and we should ignore warnings if doom-modeline is not installed.
So try this 🙏

((fboundp 'doom-modeline)
 (eval-and-compile
   (require 'doom-modeline nil 'noerror))
 (with-no-warnings
   (doom-modeline-def-segment treemacs
     "Display treemacs."
     (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace)))
                 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode)))
   (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs)))
 (doom-modeline 'treemacs))

sebastiaanspeck · 2023-08-15T07:22:51Z

Latest commit works for me (and GitHub Actions), so please test and review 🙌

seagle0128 · 2023-08-15T07:51:24Z

Try this:

((eval-and-compile (require 'doom-modeline nil 'noerror))
    (doom-modeline-def-segment treemacs
     "Display treemacs."
     (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace)))
                 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode)))
    (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs))
    (doom-modeline 'treemacs))

sebastiaanspeck · 2023-08-15T07:54:41Z

Try this:

((require 'doom-modeline nil 'noerror)
  (eval-and-compile 
    (doom-modeline-def-segment treemacs
     "Display treemacs."
     (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace)))
                 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode)))
   (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs))
 (doom-modeline 'treemacs)))

seagle0128 · 2023-08-15T08:00:45Z

Try this:

((require 'doom-modeline nil 'noerror)
  (eval-and-compile 
    (doom-modeline-def-segment treemacs
     "Display treemacs."
     (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace)))
                 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode)))
   (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs))
 (doom-modeline 'treemacs)))

should remove (fboundp 'doom-modeline)

seagle0128 · 2023-08-15T08:10:44Z

Try this:

((eval-and-compile (require 'doom-modeline nil 'noerror))
    (doom-modeline-def-segment treemacs
     "Display treemacs."
     (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace)))
                 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode)))
   (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs))
   (doom-modeline 'treemacs))

I've updated the snippet. Try it.

sebastiaanspeck · 2023-08-15T08:27:25Z

Try this:

((eval-and-compile (require 'doom-modeline nil 'noerror))
    (doom-modeline-def-segment treemacs
     "Display treemacs."
     (propertize (format " %s " (treemacs-workspace->name (treemacs-current-workspace)))
                 'face (doom-modeline-face 'doom-modeline-buffer-minor-mode)))
   (doom-modeline-def-modeline 'treemacs '(bar " " major-mode) '(treemacs))
   (doom-modeline 'treemacs))

I've updated the snippet. Try it.

In toplevel form:
src/elisp/treemacs-mode.el:2[30](https://github.com/Alexander-Miller/treemacs/actions/runs/5865108952/job/15901395417#step:8:31):43: 
Error: reference to free variable ‘treemacs-workspace-name’

gmemstr · 2023-08-15T08:52:57Z

I can confirm the current state the PR works for me!

sebastiaanspeck · 2023-08-15T09:13:18Z

It does for me as well, but the Error: reference to free variable ‘treemacs-workspace-name’ is exactly the same error we had before, or is it fixed now using native compiled code?

sebastiaanspeck · 2023-08-15T09:56:51Z

I can confirm the current state the PR works for me!

Would you be so kind to test the most recent commit? 🙏

WouterSpekkink · 2023-08-15T10:03:17Z

Works for me as well. Switching workspaces also works fine (I thought I read in an earlier comment that it didn't before).

gmemstr · 2023-08-15T10:03:39Z

Looks to be working fine for me :)

sebastiaanspeck · 2023-08-15T11:42:46Z

Thank you for testing, let's launch the 🚀 and merge this!

Alexander-Miller · 2023-08-16T20:18:06Z

All right, let's do this 🤞

Fixes #1047 and #1048

The current `doom-modeline` shows the current workspace name in `treemacs` since Alexander-Miller/treemacs#1049, thus making the `doom-modeline` useful again.

sebastiaanspeck mentioned this pull request Aug 11, 2023

[Bug] doom-modeline-def-segment results in void variable seagle0128/doom-modeline#653

Closed

3 tasks

sebastiaanspeck mentioned this pull request Aug 12, 2023

[UI] Revert changes to show current workspace name for doom-modeline #1050

Merged

sebastiaanspeck changed the title ~~Fix for doom-modeline~~ Draft: Fix for doom-modeline Aug 12, 2023

sebastiaanspeck marked this pull request as draft August 12, 2023 20:59

Alexander-Miller pushed a commit that referenced this pull request Aug 14, 2023

[UI] Revert changes to show current workspace name for doom-modeline

8a1d66f

Revert until #1049 has a working solution that also works with native compilation

sebastiaanspeck marked this pull request as ready for review August 15, 2023 05:03

sebastiaanspeck mentioned this pull request Aug 15, 2023

Treemacs + Doom Modeline on emacs 29.1 #1047

Closed

sebastiaanspeck changed the title ~~Draft: Fix for doom-modeline~~ Show workspace name in doom-modeline Aug 15, 2023

seagle0128 suggested changes Aug 15, 2023

View reviewed changes

Alexander-Miller merged commit 8be5913 into Alexander-Miller:master Aug 16, 2023
4 of 5 checks passed

[UI] Show workspace name in doom-modeline

f79c29f

Fixes #1047 and #1048

sebastiaanspeck deleted the bugfix/fix-doom-modeline branch August 17, 2023 04:24

This was referenced Mar 6, 2024

feat(treemacs): show modeline in treemacs doomemacs/themes#824

Open

Support treemacs-ext with nerd-icons instead of all-the-icons doomemacs/themes#823

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show workspace name in doom-modeline #1049

Show workspace name in doom-modeline #1049

sebastiaanspeck commented Aug 11, 2023

gmemstr commented Aug 11, 2023

jtl5770 commented Aug 11, 2023

WouterSpekkink commented Aug 12, 2023 •

edited

Loading

sebastiaanspeck commented Aug 12, 2023

WouterSpekkink commented Aug 12, 2023

gmemstr commented Aug 12, 2023

sebastiaanspeck commented Aug 12, 2023

sebastiaanspeck commented Aug 12, 2023

BlindingDark commented Aug 14, 2023 •

edited

Loading

BlindingDark commented Aug 15, 2023 •

edited

Loading

sebastiaanspeck commented Aug 15, 2023 •

edited

Loading

seagle0128 commented Aug 15, 2023

seagle0128 Aug 15, 2023 •

edited

Loading

sebastiaanspeck Aug 15, 2023

BlindingDark Aug 15, 2023 •

edited

Loading

seagle0128 Aug 15, 2023 •

edited

Loading

BlindingDark commented Aug 15, 2023

sebastiaanspeck commented Aug 15, 2023

seagle0128 commented Aug 15, 2023 •

edited

Loading

sebastiaanspeck commented Aug 15, 2023

seagle0128 commented Aug 15, 2023

seagle0128 commented Aug 15, 2023 •

edited

Loading

sebastiaanspeck commented Aug 15, 2023 •

edited

Loading

gmemstr commented Aug 15, 2023

sebastiaanspeck commented Aug 15, 2023

sebastiaanspeck commented Aug 15, 2023

WouterSpekkink commented Aug 15, 2023

gmemstr commented Aug 15, 2023

sebastiaanspeck commented Aug 15, 2023

Alexander-Miller commented Aug 16, 2023

Show workspace name in doom-modeline #1049

Show workspace name in doom-modeline #1049

Conversation

sebastiaanspeck commented Aug 11, 2023

gmemstr commented Aug 11, 2023

jtl5770 commented Aug 11, 2023

WouterSpekkink commented Aug 12, 2023 • edited Loading

sebastiaanspeck commented Aug 12, 2023

WouterSpekkink commented Aug 12, 2023

gmemstr commented Aug 12, 2023

sebastiaanspeck commented Aug 12, 2023

sebastiaanspeck commented Aug 12, 2023

BlindingDark commented Aug 14, 2023 • edited Loading

BlindingDark commented Aug 15, 2023 • edited Loading

sebastiaanspeck commented Aug 15, 2023 • edited Loading

seagle0128 commented Aug 15, 2023

seagle0128 Aug 15, 2023 • edited Loading

Choose a reason for hiding this comment

sebastiaanspeck Aug 15, 2023

Choose a reason for hiding this comment

BlindingDark Aug 15, 2023 • edited Loading

Choose a reason for hiding this comment

seagle0128 Aug 15, 2023 • edited Loading

Choose a reason for hiding this comment

BlindingDark commented Aug 15, 2023

sebastiaanspeck commented Aug 15, 2023

seagle0128 commented Aug 15, 2023 • edited Loading

sebastiaanspeck commented Aug 15, 2023

seagle0128 commented Aug 15, 2023

seagle0128 commented Aug 15, 2023 • edited Loading

sebastiaanspeck commented Aug 15, 2023 • edited Loading

gmemstr commented Aug 15, 2023

sebastiaanspeck commented Aug 15, 2023

sebastiaanspeck commented Aug 15, 2023

WouterSpekkink commented Aug 15, 2023

gmemstr commented Aug 15, 2023

sebastiaanspeck commented Aug 15, 2023

Alexander-Miller commented Aug 16, 2023

WouterSpekkink commented Aug 12, 2023 •

edited

Loading

BlindingDark commented Aug 14, 2023 •

edited

Loading

BlindingDark commented Aug 15, 2023 •

edited

Loading

sebastiaanspeck commented Aug 15, 2023 •

edited

Loading

seagle0128 Aug 15, 2023 •

edited

Loading

BlindingDark Aug 15, 2023 •

edited

Loading

seagle0128 Aug 15, 2023 •

edited

Loading

seagle0128 commented Aug 15, 2023 •

edited

Loading

seagle0128 commented Aug 15, 2023 •

edited

Loading

sebastiaanspeck commented Aug 15, 2023 •

edited

Loading